Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 Implement IObservable for Observable #80

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

MightyM17
Copy link
Contributor

@MightyM17 MightyM17 commented Oct 10, 2023

Also use onUpdate naming instead of onUpdated to be inline with the interface.

Checks:

  • Observable class implements IObservable interface correctly
  • all tests pass yarn test

Issues:

@GabrielCTroia GabrielCTroia changed the title refactor: 💡 Implment IObservable for Observable refactor: 💡 Implement IObservable for Observable Oct 10, 2023
@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest labels Oct 10, 2023
@GabrielCTroia
Copy link
Contributor

Hey @MightyM17, your PR is approved! 🎉

But before, could you please sign your commit so I can merge it! See this https://docs.github.com/articles/about-gpg/

Thank you for your contribution 🙏

Observable should implement IObservable interface, clears up confusion

✅ Closes: 77

Signed-off-by: MightyM17 <bavishimithil@gmail.com>
@MightyM17
Copy link
Contributor Author

Hey @MightyM17, your PR is approved! 🎉

But before, could you please sign your commit so I can merge it! See this https://docs.github.com/articles/about-gpg/

Thank you for your contribution 🙏

Done :D LGTM

@GabrielCTroia GabrielCTroia merged commit 63372a0 into movesthatmatter:main Oct 11, 2023
2 checks passed
@GabrielCTroia
Copy link
Contributor

Thank you @MightyM17 for your effort – you just become a Movex contributor 🎉🙏❤️!

One las thing, could you please give us a star so we can bump the repo up for #hacktoberfest today?! 🙏

Also, do you have any feedback for the project?

  • did you find it easy to navigate, to understand the docs
  • or have any other suggestion or piece of advice

Thank you once again ⭐️🥷🚀🙏

@MightyM17
Copy link
Contributor Author

Thank you @MightyM17 for your effort – you just become a Movex contributor 🎉🙏❤️!

One las thing, could you please give us a star so we can bump the repo up for #hacktoberfest today?! 🙏

Also, do you have any feedback for the project?

* did you find it easy to navigate, to understand the docs

* or have any other suggestion or piece of advice

Thank you once again ⭐️🥷🚀🙏

Happy Hacktober!
Done, starred it! :D
Yep the project was easy to navigate and codebase was not that hard to understand! Great quality code

@GabrielCTroia
Copy link
Contributor

Thank you so much for staring it and for the feedback! 🙏🎉

And, you're always welcome to comeback and contribute as much or as little as you can! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libs/movex-core-util] Refactor Observable to implement IObservable
2 participants