feat: custom secret labels #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Support for user-defined labels on secrets generated from the PostgresUser resources
Motivation
labels are commonly used on Kubernetes resources, but currently only an
app
label is hardcoded by the operator.Other Changes included in the PR
Notes
I added some very basic tests for the PostgresUser.newSecretForCR function. There were no tests for that file.
It was a huge pain to get the e2e tests working due to the old SDK versions, which cannot be build on Apple silicon. The tests are now passing after I changed the Helm install to use the updated chart/CRDs. I added a basic check for the new label map in the secret (same should be probably done for annotations as well).
I am not a Go dev by any means, so please let me know if anything needs to be worked on.
Edit: Added testing resources in #173 (comment)