Switch loaded model upon chat change #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbejar
force-pushed
the
switch-loaded-model-upon-chat-change
branch
from
1d821a8 to
03e71e6
Compare
noxware
reviewed
Jul 8, 2024
| } | ||
| } | ||
| } | ||
|
|
||
| pub fn select_chat(&mut self, chat_id: ChatID) { | ||
| self.chats.set_current_chat(chat_id); | ||
|
|
||
| if let Some(file_id) = self.get_last_used_file_id_in_current_chat() { |
There was a problem hiding this comment.
nitpick: maybe we can extract this chunk of added code to a function called self.load_last_model_for_current_chat() and call it here. Just for the sake of having smaller and self documented functions.
noxware
previously approved these changes
Jul 8, 2024
Co-authored-by: Franco Profeti <7684329+noxware@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user switches to another chat conversation, the last used model is automatically loaded.
In addition, there are two bug fixes:
Note about existing users: Chat conversations persisted with earlier versions of the app won't auto-select the last used model because this piece of data was never stored. We could use the model used in the first interaction but it doesn't seem to worth adding more code to cover such case. As far the conversation are updated, they will be persisted in our new format and the app will behave in the new way.