Delete Chat Modal #137
Merged
Delete Chat Modal #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copying delete model modal
noxware
commented
Jul 5, 2024
| let store = scope.data.get_mut::<Store>().unwrap(); | ||
| store.delete_chat(self.chat_id); | ||
| cx.widget_action(widget_uid, &scope.path, PortalAction::Close); | ||
| cx.redraw_all(); |
There was a problem hiding this comment.
Tell makepad to fully redraw to incorporate the changes from the store.
There was a problem hiding this comment.
I don't love this (because it's very rare you need to redraw the entire visible application, e.g. resizing), but I get that you're avoiding the creation of some kind of action to listen to and redraw in the relevant parts of the UI.
I think is fine for now, eventually we could add metadata to the PortalAction::Close action (so we listen to the right one) and redraw based on that.
joulei
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Recording
Screen.Recording.2024-07-05.at.12.31.06.mp4