Fix jump to bottom flicker #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noxware
commented
Jul 10, 2024
| @@ -429,6 +429,9 @@ pub struct ChatPanel { | |||
|
|
|||
| #[rust] | |||
| state: State, | |||
|
|
|||
| #[rust] | |||
| portal_list_end_reached: bool, | |||
There was a problem hiding this comment.
I will leave this separated as it's just to support this alternative to further_items_bellow_exist.
noxware
force-pushed
the
fix-jump-bottom-flicker
branch
from
69967bd to
f757a0a
Compare
noxware
force-pushed
the
fix-jump-bottom-flicker
branch
from
f757a0a to
2f9db67
Compare
noxware
commented
Jul 10, 2024
| @@ -395,6 +395,7 @@ live_design! { | |||
|
|
|||
| UserChatLine = <UserChatLine> {} | |||
| ModelChatLine = <ModelChatLine> {} | |||
| EndOfChat = <View> {height: 0.1} | |||
There was a problem hiding this comment.
We still need to render something real with non-zero height at the end to make this trick work.
jmbejar
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When you try to scroll further than the maximum possible amount, the jump to bottom button flickers.
Screen.Recording.2024-07-10.at.17.11.09.mov
Changes
Detect if the end of the list has been reached in a different way. By telling the portal list to render one more item, and when the portal list renders that, flag that the portal list reached the end.