Smooth model switch #166
Merged
Smooth model switch #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbejar
force-pushed
the
smooth-model-switch
branch
from
592bef3 to
a352148
Compare
jmbejar
force-pushed
the
wrap-up-clicking-issues
branch
from
f3636b8 to
7e94837
Compare
jmbejar
force-pushed
the
smooth-model-switch
branch
from
a352148 to
1056e1a
Compare
jmbejar
commented
Jul 24, 2024
| @@ -316,22 +316,15 @@ fn create_wasi( | |||
| file: &DownloadedFile, | |||
| load_model: &LoadModelOptions, | |||
| ) -> wasmedge_sdk::WasmEdgeResult<WasiModule> { | |||
| let ctx_size = if load_model.n_ctx > 0 { | |||
There was a problem hiding this comment.
Context: This change was originally done here https://github.com/moxin-org/moxin/blob/1056e1a0e2789f99bf7fc5ca40149b462a79c997/moxin-backend/src/backend_impls/api_server.rs#L38-L46, which is the currently active backend.
Making the change here as well since I'm removing those values from the protocol, but it does not have real effect right now.
jmbejar
commented
Jul 24, 2024
|
|
||
| ANIMATION_SPEED = 1.5; | ||
|
|
||
| Bar = <RoundedView> { |
There was a problem hiding this comment.
There is a bunch of repeated logic with other loading widget implemented, but decided to not overcomplicate this PR at this point.
jmbejar
force-pushed
the
smooth-model-switch
branch
from
ed8192d to
3f0832a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.