Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assistant message alignment #177

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Assistant message alignment #177

merged 3 commits into from
Jul 25, 2024

Conversation

noxware
Copy link
Collaborator

@noxware noxware commented Jul 25, 2024

Screenshot 2024-07-25 at 12 37 35

noxware
noxware commented Jul 25, 2024
View reviewed changes
src/chat/chat_panel.rs
@@ -122,6 +122,7 @@ live_design! {
main_section = {
body_section = {
bubble = {
padding: {left: 0, bottom: 0, top: 0}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of bubble spacing is removed for assistant messages. Although the right padding was assumed when placing the jump to bottom button, so that's preserved.

noxware
noxware commented Jul 25, 2024
View reviewed changes
src/chat/chat_line.rs
@@ -110,7 +110,7 @@ live_design! {
ChatLineBody = <View> {
width: Fill,
height: Fit,
spacing: 12,
spacing: 20,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an extra adjustment. Without the bubble, 12 as spacing between the assistant name and the message may look to tight, so I added a bit more.

jmbejar
jmbejar approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@jmbejar jmbejar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmbejar jmbejar merged commit d2e9024 into main Jul 25, 2024
15 checks passed
@jmbejar jmbejar deleted the chat-align-details branch July 25, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmbejar jmbejar jmbejar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noxware @jmbejar