fix issue 132 #191
Merged
fix issue 132 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbejar
reviewed
Aug 5, 2024
src/chat/model_selector_list.rs
Outdated
| @@ -134,7 +134,9 @@ impl Widget for ModelSelectorList { | |||
| cx.begin_turtle(walk, self.layout); | |||
|
|
|||
| if self.visible { | |||
| self.draw_items(cx, &store.downloads.downloaded_files); | |||
| if let Some(loaded_file) = store.get_loaded_downloaded_file() { | |||
There was a problem hiding this comment.
Here is an issue. It could happen that there is no loaded_file, for this reason is an Option value.
You can replicate this corner case if you go to "My Models" and remove the current active model, and go back to the chat screen:
Looks like you can send the result of store.get_loaded_downloaded_file() and attempt to unwrap it in the draw_items function.
jmbejar
approved these changes
Aug 6, 2024
|
Anyway,I also found a situation where the arrow icon shouldn't appear when there are no available models, like this. |
|
@jmbejar ,I think the arrow icon shouldn't appear when there are no available models, like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.