Use (or install) WasmEdge in the app-specific data directory *ONLY* #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relying on the system-wide installation has myriad problems; this avoids those many problems entirely by only checking the app's data directory for a WasmEdge installation and installing WasmEdge there if it is missing, which guarantees that the specific version and build characteristics of the WasmEdge installation is always under the sole control of Moxin.
|
tested and working on macOS. |
kevinaboos
changed the title
|
tested working on Linux |
|
ready to be merged |
jmbejar
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on the system-wide installation has myriad problems; this avoids those many problems entirely by only checking the app's data directory for a WasmEdge installation and installing WasmEdge there if it is missing, which guarantees that the specific version and build characteristics of the WasmEdge installation is always under the sole control of Moxin.
As a side note, I'm not sure why there are so many tiny version changes to the
Cargo.lockfile. It seems like every time i build the Moxin workspace on a different host OS, there are tons of minor version changes. Shouldn't hurt anything, but it seems odd.