Manually detect and force CUDA version passed into install_v2.sh
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `install_v2.sh` script does not properly detect CUDA installations at the moment (see moxin-org#255), so we do the detection ourselves in `moxin-runner` and then pass in the correctly-detected CUDA version as an argument into that bash script. Partially addresses moxin-org#255.
|
ready now. |
For example, a Moxin developer can save time and effort of setting up their own WasmEdge installation properly by relying on `moxin-runner` to do it for them: ```sh cargo run -p moxin-runner -- cargo build ``` All other cargo commands are supported too!
jmbejar
approved these changes
Aug 20, 2024
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
install_v2.shscript does not properly detect CUDA installations at the moment (see #255), so we do the detection ourselves inmoxin-runnerand then pass in the correctly-detected CUDA version as an argument into that bash script.Partially addresses #225.
Also, this PR allows
moxin-runnerto behave as a general cargo command runner:which saves Moxin devs a lot of time & effort because they don't have to manually install WasmEdge and set up all the necessary environment variables. Let
moxin-runnerdo it for you!Also closes #207.