Added ability that View can extend interface from other module. Now s… #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trategies of overridden methods are checked ViewStateNotMvpInterfaceTest.kt Compile kotlin test. Fixed issue. Checkstyle Fixed styles. Checkstyle Fixed styles. Test Checkstyle Fixed styles. Test
aasitnikov
requested changes
Mar 9, 2020
moxy-compiler/src/main/java/moxy/compiler/viewstate/ViewInterfaceProcessor.kt
Outdated
Show resolved
Hide resolved
moxy-compiler/src/main/java/moxy/compiler/viewstate/ViewInterfaceProcessor.kt
Outdated
Show resolved
Hide resolved
moxy-compiler/src/main/java/moxy/compiler/viewstate/ViewInterfaceProcessor.kt
Outdated
Show resolved
Hide resolved
moxy-compiler/src/main/java/moxy/compiler/viewstate/ViewInterfaceProcessor.kt
Outdated
Show resolved
Hide resolved
moxy-compiler/src/main/java/moxy/compiler/viewstate/ViewInterfaceProcessor.kt
Outdated
Show resolved
Hide resolved
moxy-compiler/src/main/java/moxy/compiler/viewstate/ViewInterfaceProcessor.kt
Show resolved
Hide resolved
moxy-compiler/src/main/java/moxy/compiler/viewstate/ViewInterfaceProcessor.kt
Show resolved
Hide resolved
moxy-compiler/src/test/java/moxy/compiler/ViewStateNotMvpInterfaceTest.kt
Outdated
Show resolved
Hide resolved
moxy-compiler/src/main/java/moxy/compiler/viewstate/ViewInterfaceProcessor.kt
Outdated
Show resolved
Hide resolved
|
Hello. Thanks for your contribution! The feature you are trying to implement in this PR is kinda big and has a lot of cases, that need to be considered. I'd like you to create an issue, describing how you want the compiler to behave in the presence of non- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability that View can extend interface from other module. Now strategies of overridden methods are checked
Added new tests ViewStateNotMvpInterfaceTest for this case