Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pen Robinson #11

Closed
branch171 opened this issue Aug 28, 2023 · 2 comments
Closed

Pen Robinson #11

branch171 opened this issue Aug 28, 2023 · 2 comments

Comments

@branch171
Copy link

Please note the Peng Robinson Coefficients are incorrect

They should be:

PengRobinson specialization

function static_coefficients(::AbstractPengRobinson)
return (0.457235529, 0.077796074, 1 + sqrt(2), 1 - sqrt(2))
end

@moyner
Copy link
Owner

moyner commented Aug 28, 2023

Hi, thanks for spotting this. I opted for eight digits accuracy in the code but there was a 7 missing for the second coefficient. I applied your patch in a commit and it will be in the next release: b010443

@moyner
Copy link
Owner

moyner commented Aug 29, 2023

MultiComponentFlash 0.1.5 is out with the adjusted coefficients. Can you see if this fixes your issue?

@moyner moyner closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants