feat: update to use pydantic for data validation #1
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the framework to use Pydantic for data validation and improves type annotations and documentation across multiple modules while also refactoring module discovery logic. Key changes include conversion of TypedDict-based models to Pydantic models, improved type hints in factory and API modules, and updates to logging configuration.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| optics_framework/common/runner/test_runnner.py | Refactored models from TypedDict to BaseModel; note potential file naming typo. |
| optics_framework/common/optics_builder.py | Updated to use Pydantic configuration; added get_text_detection method using TextFactory. |
| optics_framework/common/expose_api.py | Updated API endpoints to return Pydantic models and reworked session configuration. |
| Remaining files | Updated type annotations, refactored configuration with Pydantic, and improved documentation. |
Member
Author
|
@davidamo9 could you review this |
malto101
force-pushed
the
feature/main/pydantic
branch
from
0335a5a to
2a1ab67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.