Merged
Conversation
added 2 commits
April 3, 2025 11:11
…es, element sources , action keywords api
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new method for terminating Appium sessions while refactoring element location methods across OCR and image processing modules to support an optional index parameter, and deprecates the old locate_using_index methods.
- Refactored element location functions to accept an optional index parameter.
- Removed deprecated detection methods and updated error handling across multiple element source modules.
- Renamed the Appium session termination method from end_session to terminate and updated its usage in the session manager.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| optics_framework/engines/vision_models/ocr_models/pytesseract.py | Updated locate & find_element methods; removed deprecated detect and locate_using_index methods. |
| optics_framework/engines/vision_models/ocr_models/googlevision.py | Modified to use a unified locate API with index support; potential uninitialized variable usage. |
| optics_framework/engines/vision_models/ocr_models/easyocr.py | Refactored to include index parameter in locate and find_element; potential undefined variable issue. |
| optics_framework/engines/vision_models/image_models/templatematch.py | Updated locate and find_element_index to support an optional index parameter. |
| optics_framework/engines/elementsources/* | Removed locate_using_index methods; adjusted locate and error handling accordingly. |
| optics_framework/engines/drivers/appium.py | Renamed end_session to terminate to standardize session termination. |
| optics_framework/common/* | Updated abstract definitions for locate and find_element to accept an optional index parameter. |
| optics_framework/common/session_manager.py | Updated terminate_session to use the new terminate method on the driver. |
| optics_framework/api/action_keyword.py | Adjusted calls to use the new locate API without the deprecated locate_using_index. |
| optics_framework/engines/drivers/appium_UI_helper.py | Added a new get_locator_and_strategy_using_index helper for locating elements by index. |
Comments suppressed due to low confidence (2)
optics_framework/engines/vision_models/ocr_models/googlevision.py:76
- The variables 'top_left' and 'bottom_right' are not defined in this scope. Consider extracting these values from the OCR results (e.g., using (x, y) and (x+w, y+h)) to properly annotate the bounding box.
matches.append(((center_x, center_y), (top_left, bottom_right)))
optics_framework/engines/vision_models/ocr_models/easyocr.py:85
- The variable 'detected_texts' is not defined in this function; it appears that 'matches' should be used instead. Update the condition to check for an empty matches list.
if not detected_texts:
| """Terminates a session and cleans up resources.""" | ||
| self.sessions.pop(session_id, None) | ||
| session = self.sessions.pop(session_id, None) | ||
| session.driver.terminate() No newline at end of file |
There was a problem hiding this comment.
There's a potential bug if the session with the given session_id does not exist, as 'session' could be null before calling driver.terminate(). Consider adding a null check before attempting to terminate the driver.
Suggested change
| session.driver.terminate() | |
| if session is not None: | |
| session.driver.terminate() |
Member
|
@davidamo9 could you run pre-commit and rebase it once more |
sheshnath1st
pushed a commit
to sheshnath1st/optics-framework
that referenced
this pull request
Jan 12, 2026
# This is the 1st commit message: test(playwright): add unit test for app launch # This is the commit message mozarkai#2: test(playwright): verify youtube search box is clickable # This is the commit message mozarkai#3: test(playwright): verify youtube search box click with delay # This is the commit message mozarkai#4: test(playwright): change config sample # This is the commit message mozarkai#5: test(playwright): add youtube search box click and sleep test # This is the commit message mozarkai#6: test(playwright): add comprehensive framework feature coverage launch_app , add_and_get_element , clear_element_text , _flow , validation_methods , get_text
sheshnath1st
pushed a commit
to sheshnath1st/optics-framework
that referenced
this pull request
Jan 12, 2026
# This is the 1st commit message: refactor: centralize retry logic to remove duplication # This is the commit message mozarkai#2: refactor: centralize locator resolve+exists to eliminate duplication # This is the commit message mozarkai#3: refactor: collapse retry logic to single loop to eliminate duplication # This is the commit message mozarkai#4: refactor: remove duplicated assertion retry logic # This is the commit message mozarkai#5: refactor: remove duplicated percentage using method about # This is the commit message mozarkai#6: refactor: remove duplicated percentage using method about # This is the commit message mozarkai#7: refactor: remove duplicated percentage using method about # This is the commit message mozarkai#8: refactor: remove duplicated percentage using method about
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.