-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 525: Tracking Interface with Mlflow #750
Merged
Merged
+2,154
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njbrake
commented
Jan 27, 2025
1 task
Signed-off-by: Nathan Brake <33383515+njbrake@users.noreply.github.com>
javiermtorres
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, otherwise lgtm
javiermtorres
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
dependencies
Pull requests that update a dependency file
schemas
Changes to schemas (which may be public facing)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
This PR builds on top of the architecture changes introduced in #728.
It introduces the MLflow Tracking Client with a layer of abstraction to support other tracking backends in the future. I implemented a few mlflow methods to be sure that I correctly understand how to use the mlflow library. I have code that integrates it into our service and dependency layer, but I'll put that into a different PR.
This pull request includes significant updates to integrate MLflow for tracking machine learning experiments and workflows. The changes span environment configuration, Docker setup, backend settings, and the implementation of a new tracking client interface.
This pull request introduces significant changes to integrate MLflow for experiment tracking and management. The changes include updates to environment configurations, new MLflow-related classes and methods, and modifications to existing schemas to support MLflow.
MLflow Integration:
Environment Configuration:
MLFLOW_TRACKING_URI
and related AWS environment variables to.env.template
and.devcontainer/docker-compose.override.yaml
.mlflow
service in the Docker Compose override file.Backend Settings:
TrackingBackendType
enum andTRACKING_BACKEND
configuration inbackend/settings.py
.TRACKING_BACKEND_URI
for determining the tracking URI based on the backend type.Tracking Client Implementation:
MLflowTrackingClient
andMLflowClientManager
classes inbackend/tracking/mlflow.py
to handle MLflow operations.TrackingClient
andTrackingClientManager
inbackend/tracking/tracking_interface.py
.TrackingClientFactory
to create tracking client instances based on settings.__init__.py
to include the new tracking client manager.Schema Updates:
WorkflowCreate
,WorkflowResponse
,WorkflowSummaryResponse
, andWorkflowDetailsResponse
schemas to usestr
instead ofUUID
for IDs.Dependencies:
mlflow
to the project dependencies inpyproject.toml
.Closes #525
How to test it
This PR does not add the tracking client into the dependency or server layer, so there are no changes to behavior. However, to confirm that mlflow works in the docker-compose, run
make local-up
Additional notes for reviewers
I already...
/docs
)