Make a clean interface for jobs #939
Open
+251
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiermtorres
changed the title
4 tasks
javiermtorres
force-pushed
the
javiermtorres/issue-413-separate-interfaces
branch
2 times, most recently
from
749e962 to
411d8d7
Compare
javiermtorres
requested review from
njbrake,
ividal,
aittalam and
HareeshBahuleyan
njbrake
reviewed
Feb 21, 2025
| @@ -173,6 +173,7 @@ services: | |||
| - RAY_WORKER_GPUS_FRACTION | |||
| - LUMIGATOR_API_CORS_ALLOWED_ORIGINS | |||
| - MLFLOW_TRACKING_URI | |||
| - PYTHONPATH=/mzai/lumigator/backend:/mzai/lumigator/jobs | |||
There was a problem hiding this comment.
Seems like this should go into the dockerfile? This is required for the thing to work
There was a problem hiding this comment.
I don't like hard coding these paths into the docker file. We may need more flexibility. Let's talk about it on Monday.
njbrake
reviewed
Feb 21, 2025
javiermtorres
force-pushed
the
javiermtorres/issue-413-separate-interfaces
branch
from
411d8d7 to
fc162ce
Compare
|
@njbrake yes, I'll try to go through the usual suspects (mlflow, services/jobs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
Work in a cleaner job/backend interface mechanism
Refs #413
How to test it
Steps to test the changes:
Additional notes for reviewers
Anything you'd like to add to help the reviewer understand the changes you're proposing.
I already...
/docs)