Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Allow upload of secrets via API #963

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

API: Allow upload of secrets via API #963

wants to merge 7 commits into from
+288 −49

Conversation

javiermtorres
Copy link
Contributor

@javiermtorres javiermtorres commented Feb 20, 2025 •
edited by peteski22
Loading

What's changing

This PR provides basic support for key handling:

  • New table holding secrets (encrypted values)
  • New internal service for secrets
  • Endpoint for PUTting secrets (but not GETting)
  • One unit test case including DB checks

Depends on: #985 (will require merge once 985 goes into main)

Closes #925

How to test it

A unit test testing across all layers is included.

Additional notes for reviewers

N/A

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required
    • New revision added

@github-actions github-actions bot added backend api Changes which impact API/presentation layer schemas Changes to schemas (which may be public facing) labels Feb 20, 2025
@javiermtorres javiermtorres force-pushed the javiermtorres/issue-925-api-keys-endpoint branch from 1dcc0f8 to 12da5aa Compare February 20, 2025 22:36
@peteski22 peteski22 changed the title Add basic keys infrastructure API: Allow upload of secrets Feb 21, 2025
@peteski22 peteski22 marked this pull request as ready for review February 21, 2025 21:36
peteski22 added a commit that referenced this pull request Feb 22, 2025
@peteski22 @javiermtorres
Add service, models, records, repository, db tables and schema changes.
7a05733 
Add tests

Code as per PR: #963

Co-authored-by: javiermtorres <javier@mozilla.ai>
@peteski22 peteski22 changed the title API: Allow upload of secrets API: Allow upload of secrets via API Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api Changes which impact API/presentation layer backend schemas Changes to schemas (which may be public facing)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: API: Settings endpoint for API keys
2 participants
@javiermtorres @peteski22