This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 955999 - Running webapp-zip.js on node.js #28691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ricky Chien (RickyChien)
rickychien
force-pushed
the
webapp-zip-to-nodejs
branch
from
3ff9363 to
feda4e3
Compare
|
|
rickychien
force-pushed
the
webapp-zip-to-nodejs
branch
from
feda4e3 to
f4fe946
Compare
|
|
| @@ -1121,10 +1119,8 @@ function addEntryContentWithTime(zip, pathInZip, data, time, compression) { | |||
| input.init(data, -1, -1, 0); | |||
| } | |||
|
|
|||
| zip.addEntryStream( | |||
| pathInZip, time || 0, compression, input, false); | |||
| zip.addEntryStream(pathInZip, Date.now() * 1000, compression, input, false); | |||
There was a problem hiding this comment.
the modification time of the entry in microseconds, so I think we don't need * 1000.
There was a problem hiding this comment.
Yeah I think so. but in fact I got correct time after * 1000
rickychien
force-pushed
the
webapp-zip-to-nodejs
branch
from
f4fe946 to
e6cb523
Compare
|
|
rickychien
pushed a commit
that referenced
this pull request
Mar 10, 2015
Bug 955999 - Running webapp-zip.js on node.js r=gduan
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.