Polish: Add Placeholder ui for a State "Unavailable" #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strseb
changed the title
lesleyjanenorton
approved these changes
Aug 22, 2024
| render() { | ||
| return html` | ||
| <main class="box"> | ||
| <div style="filter:grayscale();"> |
There was a problem hiding this comment.
Curiosity/nit: Is there a reason we have these inline instead of in the CSS?
strseb
force-pushed
the
basti/placeholder
branch
from
4990c4c
to
73d459a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't handle "VPN Client unavailable" not really. We envision the that the extension should start the client using the native messaging app. So i would suggest we should have a "we're loading things" ui to represent this.
placeHolderUi.mp4