Upgrade to Neutrino 9 beta #158

armenzg · 2018-09-28T14:46:36Z

No description provided.

edmorley

Some additional changes:

the config.devtool('source-map') can now be replaced by the new built-in devtool web preset option (https://master.neutrinojs.org/packages/web/#source-maps)
the web preset's env option now allows defaults to be specified, meaning most of the manual env handling in this file can be replaced (https://master.neutrinojs.org/packages/web/#environment-variables)
the manual neutrino.config.output.publicPath('/') can be replaced by the publicPath option to the web preset
the links property of the web preset's html option will no longer have any effect (since the underlying template has changed). you'll want to either (a) switch to importing the fonts from an NPM package, (b) copy the default template and add the link there then point at the template using the template option, or (c) find an html-webpack-plugin plugin (see here) that can add them automatically to the existing template

Unrelated to the upgrade but I also spotted these:

warning " > metrics-graphics@2.12.0" has unmet peer dependency "jquery@>=1.11.1".
warning " > react-metrics-graphics@1.0.2" has incorrect peer dependency "react@^0.14.0".
warning " > react-metrics-graphics@1.0.2" has incorrect peer dependency "react-dom@^0.14.0".
warning " > postcss-cssnext@2.11.0" has unmet peer dependency "caniuse-db@^1.0.30000652".

edmorley · 2018-09-28T15:22:05Z

package.json

+    "start": "webpack-dev-server --mode development",
+    "start:local": "BACKEND=http://localhost:3000 webpack-dev-server --mode development",
+    "test": "jest",
+    "lint": "eslint --cache --ext mjs,jsx,js src",


If you'd like tests to be linted too, make this end in src tests rather than just src.
Also for parity with the yarn start / yarn build console output, optionally add --formatter codeframe.

armenzg · 2018-10-01T14:57:32Z

Hi @edmorley thanks for your help.
I've made some progress on what you mentioned, however, there's a bunch of other issues.

In general I see this warning:

 WARNING in configuration
 The 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
 You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/concepts/mode/

If I add the 'web' preset I get this failure:

ERROR in ./src/index.jsx
Module build failed (from ./node_modules/babel-loader/lib/index.js):
SyntaxError: /Users/armenzg/repos/health/frontend/src/index.jsx: Unexpected token (18:4)

  16 | const load = () => render(
  17 |   (
> 18 |     <AppContainer>
     |     ^
  19 |       <GenericErrorBoundary critical>
  20 |         <Routes />
  21 |       </GenericErrorBoundary>
    at Parser.raise (/Users/armenzg/repos/health/frontend/node_modules/@babel/parser/lib/index.js:3939:15)
    at Parser.unexpected (/Users/armenzg/repos/health/frontend/node_modules/@babel/parser/lib/index.js:5248:16)
    at Parser.parseExprAtom (/Users/armenzg/repos/health/frontend/node_modules/@babel/parser/lib/index.js:6328:20)
    at Parser.parseExprSubscripts (/Users/armenzg/repos/health/frontend/node_modules/@babel/parser/lib/index.js:5924:21)
...

If I comment out the 'web' preset I get this failure instead:

> ERROR in ./src/index.css
> Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
> ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/index.js):
> TypeError: loader._compilation.applyPluginsWaterfall is not a function
>     at /Users/armenzg/repos/health/frontend/node_modules/postcss-loader/index.js:122:43
>     at <anonymous>
>     at runLoaders (/Users/armenzg/repos/health/frontend/node_modules/webpack/lib/NormalModule.js:286:20)
>     at /Users/armenzg/repos/health/frontend/node_modules/loader-runner/lib/LoaderRunner.js:364:11
>     at /Users/armenzg/repos/health/frontend/node_modules/loader-runner/lib/LoaderRunner.js:230:18
>     at context.callback (/Users/armenzg/repos/health/frontend/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
>     at /Users/armenzg/repos/health/frontend/node_modules/postcss-loader/index.js:148:13
>     at <anonymous>
>  @ ./src/index.js 4:0-21
>  @ multi ./src/index
> 
> ERROR in ./node_modules/react-table/react-table.css
> Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
> ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/index.js):
> TypeError: loader._compilation.applyPluginsWaterfall is not a function
>     at /Users/armenzg/repos/health/frontend/node_modules/postcss-loader/index.js:122:43
>     at <anonymous>
>     at runLoaders (/Users/armenzg/repos/health/frontend/node_modules/webpack/lib/NormalModule.js:286:20)
>     at /Users/armenzg/repos/health/frontend/node_modules/loader-runner/lib/LoaderRunner.js:364:11
>     at /Users/armenzg/repos/health/frontend/node_modules/loader-runner/lib/LoaderRunner.js:230:18
>     at context.callback (/Users/armenzg/repos/health/frontend/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
>     at /Users/armenzg/repos/health/frontend/node_modules/postcss-loader/index.js:148:13
>     at <anonymous>
>  @ ./src/quantum/flow-table.js 3:0-37
>  @ ./src/routes.js
>  @ ./src/index.js
>  @ multi ./src/index
> 
> ERROR in ./node_modules/metrics-graphics/dist/metricsgraphics.css
> Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
> ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/index.js):
> TypeError: loader._compilation.applyPluginsWaterfall is not a function
>     at /Users/armenzg/repos/health/frontend/node_modules/postcss-loader/index.js:122:43
>     at <anonymous>
>     at runLoaders (/Users/armenzg/repos/health/frontend/node_modules/webpack/lib/NormalModule.js:286:20)
>     at /Users/armenzg/repos/health/frontend/node_modules/loader-runner/lib/LoaderRunner.js:364:11
>     at /Users/armenzg/repos/health/frontend/node_modules/loader-runner/lib/LoaderRunner.js:230:18
>     at context.callback (/Users/armenzg/repos/health/frontend/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
>     at /Users/armenzg/repos/health/frontend/node_modules/postcss-loader/index.js:148:13
>     at <anonymous>
>  @ ./node_modules/react-metrics-graphics/build/MetricsGraphics.js 1:4478-4530
>  @ ./src/quantum/subbenchmarks.jsx
>  @ ./src/routes.js
>  @ ./src/index.js
>  @ multi ./src/index
> error Command failed with exit code 2.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

armenzg · 2018-10-01T15:06:50Z

Also, any info about the favicon?
I'm seeing this in the console:

Failed to load resource: the server responded with a status of 404 (Not Found)

armenzg · 2018-10-01T15:09:46Z

I'm going to try to drop PostCss since it is always getting on the way.

armenzg · 2018-10-01T15:13:47Z

@edmorley it seems like order matters:
46dbec2

Should those values be instead within the react preset?

package.json

.neutrinorc.js

edmorley · 2018-10-01T15:18:21Z

In general I see this warning:

That will be fixed by setting mode - eg --mode production. If there's somewhere this can be made clearer in the docs (either the migration guide or the general preset docs), let me know :-)

edmorley · 2018-10-01T15:20:35Z

Also, any info about the favicon?

BREAKING CHANGE @neutrinojs/web, @neutrinojs/node, and their dependent presets no longer configure defaults for copying static files at build time #814. Use the @neutrinojs/copy middleware to configure this for v9.
(https://master.neutrinojs.org/migration-guide/#neutrino-v8-to-v9)

.neutrinorc.js

package.json

armenzg · 2018-10-01T17:26:06Z

Hi @edmorley this is ready to be reviewed. Thanks!

edmorley

I haven't tested locally but the Neutrino-related changes look great!

Before merging I'd recommend also doing one last rm -r yarn.lock node_modules && yarn to refresh the lockfile and pick up latest versions.

package.json

.neutrinorc.js

armenzg · 2018-10-01T19:40:46Z

Thanks for looking!
Sorry you had to look at this code mess! 😢

edmorley · 2018-10-01T20:31:49Z

It was no trouble at all - glad I could help :-)

edmorley · 2018-10-11T19:51:43Z

.neutrinorc.js

+        // Read https://stackoverflow.com/a/36623117
+        // This is the key to making React Router work with neutrino
+        // Fix issue with nested routes e.g /index/garbage
+        publicPath: '/',


I've been looking into how output.publicPath and devServer.publicPath works for some Neutrino cleanup - and remembered seeing this here. I think this may not be necessary? Reading the linked Stack Overflow issue, the problem is really fixed by using historyApiFallback, which Neutrino has enabled for some time.

Could you try removing it and confirming that both dev and prod builds work as expected? If they don't then it might be a bug that we could fix upstream.

I get this:

Ah I see - I've done some reading up on this area and think Neutrino could be setting better defaults here. I've filed:
neutrinojs/neutrino#1171

armenzg self-assigned this Sep 28, 2018

armenzg force-pushed the neutrino9 branch from eb99f96 to 02e4fe9 Compare September 28, 2018 14:58

edmorley reviewed Sep 28, 2018

View reviewed changes

edmorley reviewed Oct 1, 2018

View reviewed changes

package.json Outdated Show resolved Hide resolved

.neutrinorc.js Outdated Show resolved Hide resolved

edmorley mentioned this pull request Oct 1, 2018

Deprecate --optimize-minimize in favour of --mode production webpack/webpack-cli#624

Closed

edmorley reviewed Oct 1, 2018

View reviewed changes

.neutrinorc.js Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

armenzg force-pushed the neutrino9 branch from d64aca5 to fce554a Compare October 1, 2018 17:08

armenzg changed the title ~~WIP Upgrade to Neutrino 9 beta~~ Upgrade to Neutrino 9 beta Oct 1, 2018

edmorley approved these changes Oct 1, 2018

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

.neutrinorc.js Outdated Show resolved Hide resolved

armenzg added 7 commits October 1, 2018 15:30

Upgrade to Neutrino 9 beta

0e7ebe8

Self-host Fira Sans

9ac6aa8

Remove a warning from the console

7d1f483

Unnecessary Yarn installation

9599dc1

Drop PostCSS

2223dd0

Refresh yarn.lock to the latest dependencies

23d0a76

Sort linting rules alphabetically

0bd92e5

armenzg force-pushed the neutrino9 branch from 63e9322 to 0bd92e5 Compare October 1, 2018 19:39

armenzg merged commit 6de378a into master Oct 1, 2018

armenzg deleted the neutrino9 branch October 1, 2018 19:42

edmorley mentioned this pull request Oct 9, 2018

Neutrino 9 beta/release candidate feedback neutrinojs/neutrino#1129

Closed

edmorley reviewed Oct 11, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Neutrino 9 beta #158

Upgrade to Neutrino 9 beta #158

armenzg commented Sep 28, 2018

edmorley left a comment •

edited

Loading

edmorley Sep 28, 2018

armenzg commented Oct 1, 2018 •

edited

Loading

armenzg commented Oct 1, 2018

armenzg commented Oct 1, 2018

armenzg commented Oct 1, 2018

edmorley commented Oct 1, 2018

edmorley commented Oct 1, 2018

armenzg commented Oct 1, 2018

edmorley left a comment

armenzg commented Oct 1, 2018

edmorley commented Oct 1, 2018

edmorley Oct 11, 2018

armenzg Oct 12, 2018

edmorley Oct 12, 2018

Upgrade to Neutrino 9 beta #158

Upgrade to Neutrino 9 beta #158

Conversation

armenzg commented Sep 28, 2018

edmorley left a comment • edited Loading

Choose a reason for hiding this comment

edmorley Sep 28, 2018

Choose a reason for hiding this comment

armenzg commented Oct 1, 2018 • edited Loading

armenzg commented Oct 1, 2018

armenzg commented Oct 1, 2018

armenzg commented Oct 1, 2018

edmorley commented Oct 1, 2018

edmorley commented Oct 1, 2018

armenzg commented Oct 1, 2018

edmorley left a comment

Choose a reason for hiding this comment

armenzg commented Oct 1, 2018

edmorley commented Oct 1, 2018

edmorley Oct 11, 2018

Choose a reason for hiding this comment

armenzg Oct 12, 2018

Choose a reason for hiding this comment

edmorley Oct 12, 2018

Choose a reason for hiding this comment

edmorley left a comment •

edited

Loading

armenzg commented Oct 1, 2018 •

edited

Loading