Fix errors in uploader, add support for .config and path for config file. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gene1wood
reviewed
Apr 2, 2020
| parser.add_argument('-u', '--uri', default=credentials.uri, help='URI to Auth0 management API') | ||
| parser.add_argument('-c', '--clientid', default=credentials.client_id, required=require_creds, help='Auth0 client id') | ||
| parser.add_argument('-s', '--clientsecret', default=credentials.client_secret, required=require_creds, help='Auth0 client secret') | ||
| parser.add_argument('-i', '--clientid', default=credentials.client_id, help='Auth0 client id') |
There was a problem hiding this comment.
Will changing this break the CloudBuild CI execution of this tool?
There was a problem hiding this comment.
Sure, I can update the docs. It will break the CloudBuild CI, which is why this PR should be merged concurrently with the PR in the comment above.
There was a problem hiding this comment.
Aha, sorry didn't see that comment.
There was a problem hiding this comment.
Would you add the new config option and the credentials file location change to the docs as well?
gene1wood
suggested changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up a bunch of code, also adds checks for two different (currently unchecked) error conditions.
Note that this will require a change to the Makefile in
auth0-deploy, as-chas been changed to-i. This is reflected here: mozilla-iam/auth0-deploy#317