fix(dino-park): fix loading process for org-chart, highlight #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiji-flo
suggested changes
Jul 29, 2019
There was a problem hiding this comment.
As far as I can see this won't fix this use case: https://jira.mozilla.com/browse/IAM-158?focusedCommentId=20493&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-20493
I updated the dev extension (0.0.8) to work on prod. This will make it easier to debug this.
src/pages/PageOrgchart.vue
Outdated
| @@ -198,8 +200,8 @@ export default { | |||
| async created() { | |||
| window.addEventListener('resize', this.updateView); | |||
| this.updateView(); | |||
| await this.fetchData(); | |||
| await this.highlight(); | |||
| this.highlight(); | |||
There was a problem hiding this comment.
if we run highlight before fetchData and don't wait on it highlight won't work if the orgchart wasn't loaded before, and if it works it's just a lucky won race condition.
| @@ -198,8 +200,8 @@ export default { | |||
| async created() { | |||
There was a problem hiding this comment.
Just in general, this wouldn't need to be async anymore with your changes.
andrew-sunada
force-pushed
the
org-chart-highlight-loading
branch
2 times, most recently
from
1838ca9
to
c161a95
Compare
andrew-sunada
force-pushed
the
org-chart-highlight-loading
branch
from
9e98bf8
to
03c89f5
Compare
…interactivability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the loading times for the org chart and highlight so that the profile highlight shows up either before or starting at the same time as the org chart loading
Jira: https://jira.mozilla.com/browse/DP-1449