This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
Change idtoken_for_roles_url format to https://example.com/roles #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert the change in mozilla-iam#160 in which the URL format for idtoken_for_roles_url was changed from https://example.com/roles to https://example.com/. Now with this reversion, the idtoken_for_roles_url should again be the full URL ending in `/roles`. This change is not backwards compatible and will require that a config file or config module be changed to use the new full URL. Fixes mozilla-iam#182
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the change in #160 in which the URL format for idtoken_for_roles_url
was changed from https://example.com/roles to https://example.com/.
Now with this reversion, the idtoken_for_roles_url should again be the full
URL ending in
/roles. This change is not backwards compatible and willrequire that a config file or config module be changed to use the new full URL.
Fixes #182