VPN-6749 - fix shared addon IDs #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The “shared addons strings” for VPN (VPN PR, translations PR) had a bug - the string IDs in pontoon are of the form
CommonStringsSubtitle, and the intention wasvpn.commonStrings.subtitle. While this is non-standard (per the rest of our string IDs), it also provides an unlikely-but-real technical issue of a future clash -update.soonMessageandupdateSoon.messagefrom different parts of the YAML file would end up with the same ID ofCommonStringsUpdateSoonMessage.This PR updates the strings to the intended format.
There is another PR on the client repo to update the script to this format: mozilla-mobile/mozilla-vpn-client#10065
The two PRs must be merged at the same time, so that the subsequent ingestion script run doesn't re-introduce the bad IDs and doesn't introduce the good IDs (without translations).
Reference
VPN-6749