Issue #11864: Configure MagicNumber to ignorePropertyDeclaration to true

https://detekt.dev/compose.html#magicnumber
mozilla-mobile · Mar 24, 2022 · 067eb3c · 067eb3c
1 parent fbb0fea
commit 067eb3c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/components/ui/colors/src/main/java/mozilla/components/ui/colors/PhotonColors.kt b/components/ui/colors/src/main/java/mozilla/components/ui/colors/PhotonColors.kt
@@ -12,7 +12,6 @@ import androidx.compose.ui.graphics.Color
  * _"Firefox colors are bold, vibrant and attractive. They enhance the experience by providing visual
  * clues and by bringing attention to primary actions."_
  */
-@Suppress("MagicNumber") // It's a kind of magic ✨
 object PhotonColors {
     // Firefox Blue is one of our primary colors. We use blue as accent color for highlighting buttons,
     // links and active states like the current tab in Firefox for desktop.

diff --git a/config/detekt.yml b/config/detekt.yml
@@ -499,7 +499,7 @@ style:
       - '1'
       - '2'
     ignoreHashCodeFunction: true
-    ignorePropertyDeclaration: false
+    ignorePropertyDeclaration: true
     ignoreLocalVariableDeclaration: false
     ignoreConstantDeclaration: true
     ignoreCompanionObjectPropertyDeclaration: true