Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Fix deprecated ‘Autocomplete.LoginStorageDelegate’ with Autocomplete.StorageDelegate #10093

Closed
gabrielluong opened this issue Apr 15, 2021 · 3 comments
Closed

Fix deprecated ‘Autocomplete.LoginStorageDelegate’ with Autocomplete.StorageDelegate #10093

gabrielluong opened this issue Apr 15, 2021 · 3 comments
Assignees
@gabrielluong
Labels
<autofill> Credit Card, Addresses and Logins autofill functionality <sync-logins> Component: Sync-Logins

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Apr 15, 2021 •
edited by data-sync-user
Loading

⚠️ Deprecated ‘Autocomplete.LoginStorageDelegate’ with the intention of removing it in GeckoView v93. Please use Autocomplete.StorageDelegate instead. (bug 1691819).

https://mozilla.github.io/geckoview/javadoc/mozilla-central/org/mozilla/geckoview/doc-files/CHANGELOG

Originally posted by @pocmo in #10081 (comment)

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong changed the title Fix Deprecated ‘Autocomplete.LoginStorageDelegate’ with Autocomplete.StorageDelegate Fix deprecated ‘Autocomplete.LoginStorageDelegate’ with Autocomplete.StorageDelegate Apr 15, 2021
@gabrielluong gabrielluong added <autofill> Credit Card, Addresses and Logins autofill functionality <sync-logins> Component: Sync-Logins labels Apr 15, 2021
@csadilek
Copy link
Contributor

Let's also remove the Deprecation in Fenix when doing this: https://github.com/mozilla-mobile/fenix/pull/19078/files#diff-8ecac70de1aee8f4328f42b95277d2465c2061798690319ad9012daba98e48e7R86

@csadilek csadilek mentioned this issue Apr 16, 2021
Merged
@gabrielluong gabrielluong mentioned this issue Apr 16, 2021
Closed
@gabrielluong
Copy link
Member Author

Related Fenix ticket mozilla-mobile/fenix#19080

@gabrielluong gabrielluong self-assigned this Apr 19, 2021
@gabrielluong
Copy link
Member Author

I find myself fixing this along with the credit card prompt prework. Will take this over

@gabrielluong gabrielluong mentioned this issue Apr 22, 2021
Closed
csadilek added a commit that referenced this issue Sep 1, 2021
@csadilek
Closes #10093: Switch to new Autocomplete.StorageDelegate
329ef50
csadilek added a commit that referenced this issue Sep 1, 2021
@csadilek
Closes #10093: Switch to new Autocomplete.StorageDelegate
99764e0
@csadilek csadilek mentioned this issue Sep 1, 2021
Merged
pocmo pushed a commit that referenced this issue Sep 1, 2021
@csadilek @pocmo
Closes #10093: Switch to new Autocomplete.StorageDelegate
1d165de
grigoryk pushed a commit to gabrielluong/android-components that referenced this issue Sep 11, 2021
@csadilek
Closes mozilla-mobile#10093: Switch to new Autocomplete.StorageDelegate
ba07229
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
<autofill> Credit Card, Addresses and Logins autofill functionality <sync-logins> Component: Sync-Logins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csadilek @gabrielluong