Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Migrate feature-session to use browser-state #10209

Closed
pocmo opened this issue May 4, 2021 · 1 comment
Closed

Migrate feature-session to use browser-state #10209

pocmo opened this issue May 4, 2021 · 1 comment
Assignees
@pocmo
Labels
<session> Component: browser-session <state> Component: browser-state

Comments

@pocmo
Copy link
Contributor

pocmo commented May 4, 2021 •
edited by data-sync-user
Loading

Primarily this is about SessionUseCases.

┆Issue is synchronized with this Jira Task
@pocmo pocmo added <session> Component: browser-session <state> Component: browser-state labels May 4, 2021
@pocmo pocmo self-assigned this May 4, 2021
pocmo added a commit that referenced this issue May 4, 2021
@pocmo
Issue #10209: Migrate SessionUseCases to use BrowserStore exclusively.
2026cc7
pocmo added a commit that referenced this issue May 4, 2021
@pocmo
Issue #3532, #10209: Migrate components to use new UseCase APIs.
e8569fb
pocmo added a commit that referenced this issue May 4, 2021
@pocmo
Issue #10209: Migrate UndoMiddleware to use BrowserStore.
0f94f92
pocmo added a commit that referenced this issue May 4, 2021
@pocmo
Issue #10209: Remove browser-session dependency.
0b7fa1c
pocmo added a commit that referenced this issue May 5, 2021
@pocmo
Issue #10209: Fix UndoMiddlewareTest
b8a571a
pocmo added a commit that referenced this issue May 5, 2021
@pocmo
Issue #10209: Refactor SessionUseCasesTest to not use SessionManager.
f2e6f97
pocmo added a commit that referenced this issue May 5, 2021
@pocmo
Issue #10209: Fix SessionFeatureTest.
95fd63f
pocmo added a commit to pocmo/android-components that referenced this issue May 7, 2021
@pocmo
Complete migration from browser-session to browser-state.
20616f4 
* Issue mozilla-mobile#10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away.
* Issue mozilla-mobile#3532: Migrate TabsUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#10209: Migrate SessionUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#3532, mozilla-mobile#10209: Migrate components to use new UseCase APIs.
* Issue mozilla-mobile#10209: Migrate UndoMiddleware to use BrowserStore.
* Issue mozilla-mobile#3532: Migrate CustomTabsUseCases to use BrowserStore.
* Issue mozilla-mobile#10211: Migrate sample-browser to not depend on browser-session.
* Issue mozilla-mobile#10209: Remove browser-session dependency.
* Issue mozilla-mobile#3532: feature-tabs: Remove browser-session dependency.
* Issue mozilla-mobile#10209: Fix UndoMiddlewareTest
* Issue mozilla-mobile#10209: Refactor SessionUseCasesTest to not use SessionManager.
* Issue mozilla-mobile#10209: Fix SessionFeatureTest.
* Refactor support-migration tests to not use SessionManager.
* Fix tests in feature-contextmenu.
* Refactor feature-recentlyclosed tests to not use SessionManager
* Refactor browser-session-storage tests to not use SessionManager
* Refactor feature-intent tests to not use SessionManager
* Refactor feature-tabs tests to not use SessionManager pt. 1
* Refactor feature-customtabs tests to not depend on browser-session.
* Make sure initial load url flags are correct
* Refactor feature-tabs tests to not use SessionManager pt. 2
pocmo added a commit that referenced this issue Jun 2, 2021
@pocmo
Complete migration from browser-session to browser-state.
6780ce9 
* Issue #10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away.
* Issue #3532: Migrate TabsUseCases to use BrowserStore exclusively.
* Issue #10209: Migrate SessionUseCases to use BrowserStore exclusively.
* Issue #3532, #10209: Migrate components to use new UseCase APIs.
* Issue #10209: Migrate UndoMiddleware to use BrowserStore.
* Issue #3532: Migrate CustomTabsUseCases to use BrowserStore.
* Issue #10211: Migrate sample-browser to not depend on browser-session.
* Issue #10209: Remove browser-session dependency.
* Issue #3532: feature-tabs: Remove browser-session dependency.
* Issue #10209: Fix UndoMiddlewareTest
* Issue #10209: Refactor SessionUseCasesTest to not use SessionManager.
* Issue #10209: Fix SessionFeatureTest.
* Refactor support-migration tests to not use SessionManager.
* Fix tests in feature-contextmenu.
* Refactor feature-recentlyclosed tests to not use SessionManager
* Refactor browser-session-storage tests to not use SessionManager
* Refactor feature-intent tests to not use SessionManager
* Refactor feature-tabs tests to not use SessionManager pt. 1
* Refactor feature-customtabs tests to not depend on browser-session.
* Make sure initial load url flags are correct
* Refactor feature-tabs tests to not use SessionManager pt. 2
* Refactor browser-state tests to not depend on browser-session.
* SearchUseCasesTest: Use addTab use case instead of addPrivateTab.
* Samples Browser: Remove unused drawable.
* Fix feature-pwa tests
* Remove browser-session.
* Make sure engine session is linked for window requests
* Make sure engine session is linked when provided with tab
* Make sure engine session is linked when provided with tab pt. 2
* Prevent engine session from being created multiple times
* Prevent engine session from being created multiple times pt. 2
* Prevent engine session from being created multiple times pt. 3
* Part 4: REFACTOR ALL THE THINGS
* Update tests.
* Add additional test for multiple CreateEngineSessionAction dispatching.
* Refactor, some docs and tests
* Fix CustomTabs tests...
pocmo added a commit that referenced this issue Jun 7, 2021
@pocmo
Complete migration from browser-session to browser-state.
f5b0c94 
* Issue #10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away.
* Issue #3532: Migrate TabsUseCases to use BrowserStore exclusively.
* Issue #10209: Migrate SessionUseCases to use BrowserStore exclusively.
* Issue #3532, #10209: Migrate components to use new UseCase APIs.
* Issue #10209: Migrate UndoMiddleware to use BrowserStore.
* Issue #3532: Migrate CustomTabsUseCases to use BrowserStore.
* Issue #10211: Migrate sample-browser to not depend on browser-session.
* Issue #10209: Remove browser-session dependency.
* Issue #3532: feature-tabs: Remove browser-session dependency.
* Issue #10209: Fix UndoMiddlewareTest
* Issue #10209: Refactor SessionUseCasesTest to not use SessionManager.
* Issue #10209: Fix SessionFeatureTest.
* Refactor support-migration tests to not use SessionManager.
* Fix tests in feature-contextmenu.
* Refactor feature-recentlyclosed tests to not use SessionManager
* Refactor browser-session-storage tests to not use SessionManager
* Refactor feature-intent tests to not use SessionManager
* Refactor feature-tabs tests to not use SessionManager pt. 1
* Refactor feature-customtabs tests to not depend on browser-session.
* Make sure initial load url flags are correct
* Refactor feature-tabs tests to not use SessionManager pt. 2
* Refactor browser-state tests to not depend on browser-session.
* SearchUseCasesTest: Use addTab use case instead of addPrivateTab.
* Samples Browser: Remove unused drawable.
* Fix feature-pwa tests
* Remove browser-session.
* Make sure engine session is linked for window requests
* Make sure engine session is linked when provided with tab
* Make sure engine session is linked when provided with tab pt. 2
* Prevent engine session from being created multiple times
* Prevent engine session from being created multiple times pt. 2
* Prevent engine session from being created multiple times pt. 3
* Part 4: REFACTOR ALL THE THINGS
* Update tests.
* Add additional test for multiple CreateEngineSessionAction dispatching.
* Refactor, some docs and tests
* Fix CustomTabs tests...
mergify bot pushed a commit that referenced this issue Jun 7, 2021
@pocmo @mergify
Complete migration from browser-session to browser-state.
dd55e0f 
* Issue #10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away.
* Issue #3532: Migrate TabsUseCases to use BrowserStore exclusively.
* Issue #10209: Migrate SessionUseCases to use BrowserStore exclusively.
* Issue #3532, #10209: Migrate components to use new UseCase APIs.
* Issue #10209: Migrate UndoMiddleware to use BrowserStore.
* Issue #3532: Migrate CustomTabsUseCases to use BrowserStore.
* Issue #10211: Migrate sample-browser to not depend on browser-session.
* Issue #10209: Remove browser-session dependency.
* Issue #3532: feature-tabs: Remove browser-session dependency.
* Issue #10209: Fix UndoMiddlewareTest
* Issue #10209: Refactor SessionUseCasesTest to not use SessionManager.
* Issue #10209: Fix SessionFeatureTest.
* Refactor support-migration tests to not use SessionManager.
* Fix tests in feature-contextmenu.
* Refactor feature-recentlyclosed tests to not use SessionManager
* Refactor browser-session-storage tests to not use SessionManager
* Refactor feature-intent tests to not use SessionManager
* Refactor feature-tabs tests to not use SessionManager pt. 1
* Refactor feature-customtabs tests to not depend on browser-session.
* Make sure initial load url flags are correct
* Refactor feature-tabs tests to not use SessionManager pt. 2
* Refactor browser-state tests to not depend on browser-session.
* SearchUseCasesTest: Use addTab use case instead of addPrivateTab.
* Samples Browser: Remove unused drawable.
* Fix feature-pwa tests
* Remove browser-session.
* Make sure engine session is linked for window requests
* Make sure engine session is linked when provided with tab
* Make sure engine session is linked when provided with tab pt. 2
* Prevent engine session from being created multiple times
* Prevent engine session from being created multiple times pt. 2
* Prevent engine session from being created multiple times pt. 3
* Part 4: REFACTOR ALL THE THINGS
* Update tests.
* Add additional test for multiple CreateEngineSessionAction dispatching.
* Refactor, some docs and tests
* Fix CustomTabs tests...
pocmo added a commit to pocmo/android-components that referenced this issue Jun 8, 2021
@pocmo
Complete migration from browser-session to browser-state.
ea79c34 
* Issue mozilla-mobile#10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away.
* Issue mozilla-mobile#3532: Migrate TabsUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#10209: Migrate SessionUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#3532, mozilla-mobile#10209: Migrate components to use new UseCase APIs.
* Issue mozilla-mobile#10209: Migrate UndoMiddleware to use BrowserStore.
* Issue mozilla-mobile#3532: Migrate CustomTabsUseCases to use BrowserStore.
* Issue mozilla-mobile#10211: Migrate sample-browser to not depend on browser-session.
* Issue mozilla-mobile#10209: Remove browser-session dependency.
* Issue mozilla-mobile#3532: feature-tabs: Remove browser-session dependency.
* Issue mozilla-mobile#10209: Fix UndoMiddlewareTest
* Issue mozilla-mobile#10209: Refactor SessionUseCasesTest to not use SessionManager.
* Issue mozilla-mobile#10209: Fix SessionFeatureTest.
* Refactor support-migration tests to not use SessionManager.
* Fix tests in feature-contextmenu.
* Refactor feature-recentlyclosed tests to not use SessionManager
* Refactor browser-session-storage tests to not use SessionManager
* Refactor feature-intent tests to not use SessionManager
* Refactor feature-tabs tests to not use SessionManager pt. 1
* Refactor feature-customtabs tests to not depend on browser-session.
* Make sure initial load url flags are correct
* Refactor feature-tabs tests to not use SessionManager pt. 2
* Refactor browser-state tests to not depend on browser-session.
* SearchUseCasesTest: Use addTab use case instead of addPrivateTab.
* Samples Browser: Remove unused drawable.
* Fix feature-pwa tests
* Remove browser-session.
* Make sure engine session is linked for window requests
* Make sure engine session is linked when provided with tab
* Make sure engine session is linked when provided with tab pt. 2
* Prevent engine session from being created multiple times
* Prevent engine session from being created multiple times pt. 2
* Prevent engine session from being created multiple times pt. 3
* Part 4: REFACTOR ALL THE THINGS
* Update tests.
* Add additional test for multiple CreateEngineSessionAction dispatching.
* Refactor, some docs and tests
* Fix CustomTabs tests...
@pocmo pocmo mentioned this issue Jun 8, 2021
Merged
4 tasks
pocmo added a commit to pocmo/android-components that referenced this issue Jun 8, 2021
@pocmo
Complete migration from browser-session to browser-state.
c8ea639 
* Issue mozilla-mobile#10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away.
* Issue mozilla-mobile#3532: Migrate TabsUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#10209: Migrate SessionUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#3532, mozilla-mobile#10209: Migrate components to use new UseCase APIs.
* Issue mozilla-mobile#10209: Migrate UndoMiddleware to use BrowserStore.
* Issue mozilla-mobile#3532: Migrate CustomTabsUseCases to use BrowserStore.
* Issue mozilla-mobile#10211: Migrate sample-browser to not depend on browser-session.
* Issue mozilla-mobile#10209: Remove browser-session dependency.
* Issue mozilla-mobile#3532: feature-tabs: Remove browser-session dependency.
* Issue mozilla-mobile#10209: Fix UndoMiddlewareTest
* Issue mozilla-mobile#10209: Refactor SessionUseCasesTest to not use SessionManager.
* Issue mozilla-mobile#10209: Fix SessionFeatureTest.
* Refactor support-migration tests to not use SessionManager.
* Fix tests in feature-contextmenu.
* Refactor feature-recentlyclosed tests to not use SessionManager
* Refactor browser-session-storage tests to not use SessionManager
* Refactor feature-intent tests to not use SessionManager
* Refactor feature-tabs tests to not use SessionManager pt. 1
* Refactor feature-customtabs tests to not depend on browser-session.
* Make sure initial load url flags are correct
* Refactor feature-tabs tests to not use SessionManager pt. 2
* Refactor browser-state tests to not depend on browser-session.
* SearchUseCasesTest: Use addTab use case instead of addPrivateTab.
* Samples Browser: Remove unused drawable.
* Fix feature-pwa tests
* Remove browser-session.
* Make sure engine session is linked for window requests
* Make sure engine session is linked when provided with tab
* Make sure engine session is linked when provided with tab pt. 2
* Prevent engine session from being created multiple times
* Prevent engine session from being created multiple times pt. 2
* Prevent engine session from being created multiple times pt. 3
* Part 4: REFACTOR ALL THE THINGS
* Update tests.
* Add additional test for multiple CreateEngineSessionAction dispatching.
* Refactor, some docs and tests
* Fix CustomTabs tests...
mergify bot pushed a commit that referenced this issue Jun 8, 2021
@pocmo @mergify
Complete migration from browser-session to browser-state.
e535713 
* Issue #10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away.
* Issue #3532: Migrate TabsUseCases to use BrowserStore exclusively.
* Issue #10209: Migrate SessionUseCases to use BrowserStore exclusively.
* Issue #3532, #10209: Migrate components to use new UseCase APIs.
* Issue #10209: Migrate UndoMiddleware to use BrowserStore.
* Issue #3532: Migrate CustomTabsUseCases to use BrowserStore.
* Issue #10211: Migrate sample-browser to not depend on browser-session.
* Issue #10209: Remove browser-session dependency.
* Issue #3532: feature-tabs: Remove browser-session dependency.
* Issue #10209: Fix UndoMiddlewareTest
* Issue #10209: Refactor SessionUseCasesTest to not use SessionManager.
* Issue #10209: Fix SessionFeatureTest.
* Refactor support-migration tests to not use SessionManager.
* Fix tests in feature-contextmenu.
* Refactor feature-recentlyclosed tests to not use SessionManager
* Refactor browser-session-storage tests to not use SessionManager
* Refactor feature-intent tests to not use SessionManager
* Refactor feature-tabs tests to not use SessionManager pt. 1
* Refactor feature-customtabs tests to not depend on browser-session.
* Make sure initial load url flags are correct
* Refactor feature-tabs tests to not use SessionManager pt. 2
* Refactor browser-state tests to not depend on browser-session.
* SearchUseCasesTest: Use addTab use case instead of addPrivateTab.
* Samples Browser: Remove unused drawable.
* Fix feature-pwa tests
* Remove browser-session.
* Make sure engine session is linked for window requests
* Make sure engine session is linked when provided with tab
* Make sure engine session is linked when provided with tab pt. 2
* Prevent engine session from being created multiple times
* Prevent engine session from being created multiple times pt. 2
* Prevent engine session from being created multiple times pt. 3
* Part 4: REFACTOR ALL THE THINGS
* Update tests.
* Add additional test for multiple CreateEngineSessionAction dispatching.
* Refactor, some docs and tests
* Fix CustomTabs tests...
@pocmo
Copy link
Contributor Author

pocmo commented Jun 23, 2021

Done!

@pocmo pocmo closed this as completed Jun 23, 2021
grigoryk pushed a commit to gabrielluong/android-components that referenced this issue Sep 11, 2021
@pocmo
Complete migration from browser-session to browser-state.
71aac85 
* Issue mozilla-mobile#10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away.
* Issue mozilla-mobile#3532: Migrate TabsUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#10209: Migrate SessionUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#3532, mozilla-mobile#10209: Migrate components to use new UseCase APIs.
* Issue mozilla-mobile#10209: Migrate UndoMiddleware to use BrowserStore.
* Issue mozilla-mobile#3532: Migrate CustomTabsUseCases to use BrowserStore.
* Issue mozilla-mobile#10211: Migrate sample-browser to not depend on browser-session.
* Issue mozilla-mobile#10209: Remove browser-session dependency.
* Issue mozilla-mobile#3532: feature-tabs: Remove browser-session dependency.
* Issue mozilla-mobile#10209: Fix UndoMiddlewareTest
* Issue mozilla-mobile#10209: Refactor SessionUseCasesTest to not use SessionManager.
* Issue mozilla-mobile#10209: Fix SessionFeatureTest.
* Refactor support-migration tests to not use SessionManager.
* Fix tests in feature-contextmenu.
* Refactor feature-recentlyclosed tests to not use SessionManager
* Refactor browser-session-storage tests to not use SessionManager
* Refactor feature-intent tests to not use SessionManager
* Refactor feature-tabs tests to not use SessionManager pt. 1
* Refactor feature-customtabs tests to not depend on browser-session.
* Make sure initial load url flags are correct
* Refactor feature-tabs tests to not use SessionManager pt. 2
* Refactor browser-state tests to not depend on browser-session.
* SearchUseCasesTest: Use addTab use case instead of addPrivateTab.
* Samples Browser: Remove unused drawable.
* Fix feature-pwa tests
* Remove browser-session.
* Make sure engine session is linked for window requests
* Make sure engine session is linked when provided with tab
* Make sure engine session is linked when provided with tab pt. 2
* Prevent engine session from being created multiple times
* Prevent engine session from being created multiple times pt. 2
* Prevent engine session from being created multiple times pt. 3
* Part 4: REFACTOR ALL THE THINGS
* Update tests.
* Add additional test for multiple CreateEngineSessionAction dispatching.
* Refactor, some docs and tests
* Fix CustomTabs tests...
grigoryk pushed a commit to gabrielluong/android-components that referenced this issue Sep 11, 2021
@pocmo
Complete migration from browser-session to browser-state.
faba4bf 
* Issue mozilla-mobile#10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away.
* Issue mozilla-mobile#3532: Migrate TabsUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#10209: Migrate SessionUseCases to use BrowserStore exclusively.
* Issue mozilla-mobile#3532, mozilla-mobile#10209: Migrate components to use new UseCase APIs.
* Issue mozilla-mobile#10209: Migrate UndoMiddleware to use BrowserStore.
* Issue mozilla-mobile#3532: Migrate CustomTabsUseCases to use BrowserStore.
* Issue mozilla-mobile#10211: Migrate sample-browser to not depend on browser-session.
* Issue mozilla-mobile#10209: Remove browser-session dependency.
* Issue mozilla-mobile#3532: feature-tabs: Remove browser-session dependency.
* Issue mozilla-mobile#10209: Fix UndoMiddlewareTest
* Issue mozilla-mobile#10209: Refactor SessionUseCasesTest to not use SessionManager.
* Issue mozilla-mobile#10209: Fix SessionFeatureTest.
* Refactor support-migration tests to not use SessionManager.
* Fix tests in feature-contextmenu.
* Refactor feature-recentlyclosed tests to not use SessionManager
* Refactor browser-session-storage tests to not use SessionManager
* Refactor feature-intent tests to not use SessionManager
* Refactor feature-tabs tests to not use SessionManager pt. 1
* Refactor feature-customtabs tests to not depend on browser-session.
* Make sure initial load url flags are correct
* Refactor feature-tabs tests to not use SessionManager pt. 2
* Refactor browser-state tests to not depend on browser-session.
* SearchUseCasesTest: Use addTab use case instead of addPrivateTab.
* Samples Browser: Remove unused drawable.
* Fix feature-pwa tests
* Remove browser-session.
* Make sure engine session is linked for window requests
* Make sure engine session is linked when provided with tab
* Make sure engine session is linked when provided with tab pt. 2
* Prevent engine session from being created multiple times
* Prevent engine session from being created multiple times pt. 2
* Prevent engine session from being created multiple times pt. 3
* Part 4: REFACTOR ALL THE THINGS
* Update tests.
* Add additional test for multiple CreateEngineSessionAction dispatching.
* Refactor, some docs and tests
* Fix CustomTabs tests...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
<session> Component: browser-session <state> Component: browser-state
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pocmo