Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Refactor LoginPickerView to a more generic view #10216

Closed
gabrielluong opened this issue May 4, 2021 · 0 comments · Fixed by #10226
Closed

Refactor LoginPickerView to a more generic view #10216

gabrielluong opened this issue May 4, 2021 · 0 comments · Fixed by #10226
Assignees
@gabrielluong
Labels
<prompts> Component: feature-prompts
Milestone
90.0.0 🌳

Comments

@gabrielluong
Copy link
Member

gabrielluong commented May 4, 2021 •
edited by data-sync-user
Loading

Refactor LoginPickerView to something more generic so it can take a type for Login or CreditCard. We're adding select credit card prompt which is very similar to the select login prompt. I would like to reuse the existing LoginPickerView due to the similarities and refactor it into a more generic interface that can account for any selectable list of options (logins, addresses, credit cards).

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added <autofill> Credit Card, Addresses and Logins autofill functionality cc-autofill <prompts> Component: feature-prompts and removed <autofill> Credit Card, Addresses and Logins autofill functionality labels May 4, 2021
@gabrielluong gabrielluong self-assigned this May 4, 2021
@gabrielluong gabrielluong added this to the 90.0.0 🌳 milestone May 4, 2021
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 5, 2021
@gabrielluong
Issue mozilla-mobile#10216: Refactor LoginPickerView to a more generi…
880d407 
…c view SelectablePromptView
@gabrielluong gabrielluong mentioned this issue May 5, 2021
Merged
4 tasks
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 5, 2021
@gabrielluong
Issue mozilla-mobile#10216: Refactor LoginPickerView to a more generi…
c5fda3b 
…c view SelectablePromptView
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 6, 2021
@gabrielluong
Issue mozilla-mobile#10216: Refactor LoginPickerView to a more generi…
a462b83 
…c view SelectablePromptView
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 6, 2021
@gabrielluong
Issue mozilla-mobile#10216: Refactor LoginPickerView to a more generi…
76b24a5 
…c view SelectablePromptView
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 6, 2021
@gabrielluong
Issue mozilla-mobile#10216: Refactor LoginPickerView to a more generi…
7badf84 
…c view SelectablePromptView
@mergify mergify bot closed this as completed in #10226 May 7, 2021
mergify bot pushed a commit that referenced this issue May 7, 2021
@gabrielluong @mergify
Issue #10216: Refactor LoginPickerView to a more generic view Selecta…
0f11c79 
…blePromptView
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
<prompts> Component: feature-prompts
Projects
None yet
Milestone
90.0.0 🌳
1 participant
@gabrielluong