Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Cancel download prompt #11411

Closed
mavduevskiy opened this issue Dec 15, 2021 · 0 comments
Closed

Cancel download prompt #11411

mavduevskiy opened this issue Dec 15, 2021 · 0 comments

Comments

@mavduevskiy
Copy link
Contributor

mavduevskiy commented Dec 15, 2021

Relates to the ...fenix/18160.
Short version:
adding a prompt that warns the user about cancellation of active downloads.

Long version:
We are adding new business logic to closing private tabs. Now it will check for active private downloads.

After a lot of consideration if it should be implemented as part of the feature/storage inside AC or inside the controller/interactor inside Fenix, we agreed that AC implementation would be much more verbose. Hence, AC recieves the prompt itself, but the calling logic would reside in the Fenix project.

Logic:
If the action leads to having zero private tabs, app warns the user that all private downloads will be finished.
A user can

  1. close each private tab individually,
  2. close all private tabs from the three dot menu and
  3. close all private tabs from Firefox Private notification with the corresponding action.

Current implementation of the warning on the fenix side would cover the first two scenarios.

┆Issue is synchronized with this Jira Task

mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 15, 2021
Refactored and extended tests
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 15, 2021
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 15, 2021
fixed link issues
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 16, 2021
fixed lint issue
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 16, 2021
Refactored and extended tests
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 16, 2021
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 16, 2021
fixed link issues
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 16, 2021
fixed lint issue
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 16, 2021
fixed strings descriptions for the translators
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 16, 2021
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 17, 2021
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 20, 2021
mavduevskiy pushed a commit to mavduevskiy/android-components that referenced this issue Dec 20, 2021
@mergify mergify bot closed this as completed in 152a542 Dec 20, 2021
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 24, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 24, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
JohanLorenzo pushed a commit to JohanLorenzo/android-l10n that referenced this issue Oct 25, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
JohanLorenzo pushed a commit to JohanLorenzo/android-l10n that referenced this issue Oct 25, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
JohanLorenzo pushed a commit to JohanLorenzo/android-l10n that referenced this issue Oct 25, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
JohanLorenzo pushed a commit to JohanLorenzo/android-l10n that referenced this issue Oct 25, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 25, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 26, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 27, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 27, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 27, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 27, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 28, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 28, 2022
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 13, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 13, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 13, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 13, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 15, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 15, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 15, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 18, 2023
…ownloads prompt

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@07ea3d8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant