Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Synced tabs state refresh will always fail after authentication #11894

Closed
MatthewTighe opened this issue Mar 18, 2022 · 0 comments · Fixed by #11895
Closed

Synced tabs state refresh will always fail after authentication #11894

MatthewTighe opened this issue Mar 18, 2022 · 0 comments · Fixed by #11895
Assignees
@MatthewTighe
Labels
<sync-tabs> Components: concept-storage

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Mar 18, 2022 •
edited by data-sync-user
Loading

The synced tabs DefaultPresenter defines a SyncedTabsAccountObserver that refreshesSyncedTabs() once an account has been authenticated. However, the implementation of refreshSyncedTabs requires that device state be populated, in order to map devices to their synced tabs. Since FxaDeviceConstellation::refreshDevices isn't called prior to this, the tab refresh fails erroneously.

┆Issue is synchronized with this Jira Task
@MatthewTighe MatthewTighe added the <sync-tabs> Components: concept-storage label Mar 18, 2022
@MatthewTighe MatthewTighe self-assigned this Mar 18, 2022
MatthewTighe added a commit to MatthewTighe/android-components that referenced this issue Mar 18, 2022
@MatthewTighe
closes mozilla-mobile#11894: sync devices on authentication
5671f94
@MatthewTighe MatthewTighe mentioned this issue Mar 18, 2022
Merged
MatthewTighe added a commit to MatthewTighe/android-components that referenced this issue Mar 18, 2022
@MatthewTighe
closes mozilla-mobile#11894: sync devices on authentication
b9e1bd2
MatthewTighe added a commit to MatthewTighe/android-components that referenced this issue Mar 18, 2022
@MatthewTighe
closes mozilla-mobile#11894: sync devices on authentication
31cc1c2
MatthewTighe added a commit to MatthewTighe/android-components that referenced this issue Mar 18, 2022
@MatthewTighe
closes mozilla-mobile#11894: sync devices on authentication
ffd771a
MatthewTighe added a commit to MatthewTighe/android-components that referenced this issue Mar 21, 2022
@MatthewTighe
closes mozilla-mobile#11894: sync devices on authentication
3e7070b
@mergify mergify bot closed this as completed in #11895 Mar 21, 2022
mergify bot pushed a commit that referenced this issue Mar 21, 2022
@MatthewTighe @mergify
closes #11894: sync devices on authentication
a5f7201
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Oct 31, 2022
@MatthewTighe @mergify
[components] closes mozilla-mobile/android-components#11894: sync dev…
8d25f7a 
…ices on authentication
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MatthewTighe MatthewTighe

Labels
<sync-tabs> Components: concept-storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

closes #11894: sync devices on authentication MatthewTighe/android-components
1 participant
@MatthewTighe