Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support updating Pocket stories with missing image path #11905

Closed
Mugurell opened this issue Mar 21, 2022 · 2 comments
Closed

Support updating Pocket stories with missing image path #11905

Mugurell opened this issue Mar 21, 2022 · 2 comments
Assignees
@Mugurell

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Mar 21, 2022 •
edited by data-sync-user
Loading

Issue seen in mozilla-mobile/fenix#24362

Based on mozilla-mobile/fenix#21626 we should've filtered out these stories.
Not happening atm because in these cases the url actually has the form "https://img-getpocket.cdn.mozilla.net/{wh}/filters:format(jpeg):quality(60):no_upscale():strip_exif()/ null "

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Mar 21, 2022
Mugurell added a commit to Mugurell/android-components that referenced this issue Mar 21, 2022
@Mugurell
For mozilla-mobile#11905 - Filter out Pocket stories with missing ima…
4684570 
…ge path
Mugurell added a commit to Mugurell/android-components that referenced this issue Mar 21, 2022
@Mugurell
For mozilla-mobile#11905 - Filter out Pocket stories with missing ima…
5940320 
…ge path
@Mugurell
Copy link
Contributor Author

This will first be tried to be fixed on Pocket's side.

Mugurell added a commit to Mugurell/android-components that referenced this issue Mar 23, 2022
@Mugurell
For mozilla-mobile#11905 - Delete pocket story also when imageUrl cha…
537bd06 
…nges

This will allow updated imageUrls to be persisted and offered to clients.
Mugurell added a commit to Mugurell/android-components that referenced this issue Mar 23, 2022
@Mugurell
For mozilla-mobile#11905 - Delete pocket story also when imageUrl cha…
dcf2a5e 
…nges

This will allow updated imageUrls to be persisted and offered to clients.
Mugurell added a commit to Mugurell/android-components that referenced this issue Mar 24, 2022
@Mugurell
For mozilla-mobile#11905 - Delete pocket story also when imageUrl cha…
40c2c29 
…nges

This will allow updated imageUrls to be persisted and offered to clients.
mergify bot pushed a commit that referenced this issue Mar 24, 2022
@Mugurell @mergify
For #11905 - Delete pocket story also when imageUrl changes
5e6055b 
This will allow updated imageUrls to be persisted and offered to clients.
@Mugurell Mugurell changed the title Filter out Pocket stories with missing image path Support updating Pocket stories with missing image path Mar 24, 2022
mergify bot pushed a commit that referenced this issue Mar 25, 2022
@Mugurell
For #11905 - Delete pocket story also when imageUrl changes
416bd5b 
This will allow updated imageUrls to be persisted and offered to clients.

(cherry picked from commit 5e6055b)

# Conflicts:
#	docs/changelog.md
Mugurell added a commit that referenced this issue Mar 25, 2022
@Mugurell
For #11905 - Delete pocket story also when imageUrl changes
c148b01 
This will allow updated imageUrls to be persisted and offered to clients.

(cherry picked from commit 5e6055b)

# Conflicts:
#	docs/changelog.md
mergify bot pushed a commit that referenced this issue Mar 25, 2022
@Mugurell @mergify
For #11905 - Delete pocket story also when imageUrl changes
f3aef8e 
This will allow updated imageUrls to be persisted and offered to clients.

(cherry picked from commit 5e6055b)

# Conflicts:
#	docs/changelog.md
@Mugurell
Copy link
Contributor Author

Closing this. Results to be observed in Fenix - mozilla-mobile/fenix#24362 after Pocket updates the sent data.

@Mugurell Mugurell mentioned this issue Mar 25, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mugurell