Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Apply remaining UI updates from CustomTabConfig #306

Closed
csadilek opened this issue Jun 19, 2018 · 2 comments
Closed

Apply remaining UI updates from CustomTabConfig #306

csadilek opened this issue Jun 19, 2018 · 2 comments
Labels
🌟 feature New functionality and improvements

Comments

@csadilek
Copy link
Contributor

csadilek commented Jun 19, 2018 •
edited by data-sync-user
Loading

In #282 we only addressed the toolbarColor. All remaining configurations still need to be applied.

┆Issue is synchronized with this Jira Task
@csadilek csadilek mentioned this issue Jun 19, 2018
Merged
@pocmo pocmo added the 🌟 feature New functionality and improvements label Jun 19, 2018
@pocmo
Copy link
Contributor

pocmo commented Jan 17, 2019

@jonalmeida I think we can close this one since you have separate issues for the custom tab related UI changes, right?

I also noticed that we have a comment about this in ToolbarPresenter.initializeView. Since you created a separate feature for that we may be able to remove the comment?

@jonalmeida
Copy link
Contributor

Yes, I think so since mozilla-mobile/reference-browser#209 lists all main Custom Tab configurations to apply.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🌟 feature New functionality and improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pocmo @csadilek @jonalmeida