Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Recover when content process gets killed #3310

Closed
pocmo opened this issue Jun 7, 2019 · 2 comments
Closed

Recover when content process gets killed #3310

pocmo opened this issue Jun 7, 2019 · 2 comments
Assignees
@pocmo
Labels
<engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix P1
Milestone
6.0.0 💺

Comments

@pocmo
Copy link
Contributor

pocmo commented Jun 7, 2019 •
edited by data-sync-user
Loading

Fenix issue: mozilla-mobile/fenix#1577
GeckoView bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1557096

Currently we see onCrash() getting called for a GeckoSession - but we have no clue whether that is a crash or whether the content process just got killed by Android to reclaim some resources.

We can handle crashes (via lib-crash) and allow the user to restore manually - but we need a way to know whether a call to onCrash() was just for a process kill so that we can auto-restore.

┆Issue is synchronized with this Jira Task
@pocmo pocmo added 🌟 feature New functionality and improvements <engine-gecko> Component: browser-engine-gecko 🐉 Fenix Feature needed for Fenix needs:gv To implement/fix this we need a new API in GeckoView labels Jun 7, 2019
@pocmo pocmo mentioned this issue Jun 7, 2019
Closed
@vesta0 vesta0 added the P1 label Jun 10, 2019
@pocmo pocmo mentioned this issue Jul 16, 2019
Closed
@pocmo pocmo self-assigned this Jul 16, 2019
@pocmo pocmo removed the needs:gv To implement/fix this we need a new API in GeckoView label Jul 16, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Jul 16, 2019
@pocmo
Closes mozilla-mobile#3310: browser-engine-gecko-nightly: Automatical…
ff917d7 
…ly recover and restore if content process is killed.
pocmo added a commit to pocmo/android-components that referenced this issue Jul 16, 2019
@pocmo
Closes mozilla-mobile#3310: browser-engine-gecko-nightly: Automatical…
ed1c39b 
…ly recover and restore if content process is killed.
pocmo added a commit to pocmo/android-components that referenced this issue Jul 16, 2019
@pocmo
Closes mozilla-mobile#3310: browser-engine-gecko-nightly: Automatical…
c7c3ba0 
…ly recover and restore if content process is killed.
@pocmo pocmo added the blocked Blocked pull requests and issues label Jul 17, 2019
@pocmo
Copy link
Contributor Author

pocmo commented Jul 17, 2019

Blocked: The added GeckoView API was backed out due to regressions :(
https://bugzilla.mozilla.org/show_bug.cgi?id=1557096

@jonalmeida jonalmeida removed the blocked Blocked pull requests and issues label Jul 22, 2019
@jonalmeida
Copy link
Contributor

jonalmeida commented Jul 22, 2019 •
edited
Loading

This is no longer blocked on nightly GV. The ContentDelegate.onKill API is now available.

@jonalmeida jonalmeida mentioned this issue Jul 22, 2019
Closed
pocmo added a commit to pocmo/android-components that referenced this issue Jul 23, 2019
@pocmo
Closes mozilla-mobile#3310: browser-engine-gecko-nightly: Automatical…
dff7c89 
…ly recover and restore if content process is killed.
@pocmo pocmo closed this as completed in cf82f8e Jul 23, 2019
@pocmo pocmo mentioned this issue Jul 23, 2019
Closed
@pocmo pocmo added this to the 6.0.0 💺 milestone Jul 30, 2019
@pocmo pocmo mentioned this issue Jul 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
<engine-gecko> Component: browser-engine-gecko 🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix P1
Projects
None yet
Milestone
6.0.0 💺
Development

No branches or pull requests
3 participants
@pocmo @jonalmeida @vesta0