Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Migrate feature-downloads to use browser-state #4282

Closed
pocmo opened this issue Sep 2, 2019 · 1 comment
Closed

Migrate feature-downloads to use browser-state #4282

pocmo opened this issue Sep 2, 2019 · 1 comment
Assignees
@pocmo
Labels
<download> Component: feature-download 🌟 feature New functionality and improvements <state> Component: browser-state
Milestone
13.0.0 🌌

Comments

@pocmo
Copy link
Contributor

pocmo commented Sep 2, 2019 •
edited by data-sync-user
Loading

┆Issue is synchronized with this Jira Task
@pocmo pocmo added 🌟 feature New functionality and improvements <download> Component: feature-download <state> Component: browser-state labels Sep 2, 2019
@pocmo pocmo mentioned this issue Sep 2, 2019
Closed
@pocmo pocmo mentioned this issue Sep 5, 2019
Merged
@csadilek
Copy link
Contributor

csadilek commented Sep 5, 2019

Just adding a note here to also refactor how we handle download IDs in our FetchDownloadService, see: #4315 (comment)

@pocmo pocmo self-assigned this Sep 9, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Sep 12, 2019
@pocmo
Closes mozilla-mobile#4282: Migrate feature-downloads to use browser-…
bb51ae4 
…state.
pocmo added a commit to pocmo/android-components that referenced this issue Sep 12, 2019
@pocmo
Closes mozilla-mobile#4282: Migrate feature-downloads to use browser-…
38eee72 
…state.
@pocmo pocmo added this to the 13.0.0 🌌 milestone Sep 12, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Sep 13, 2019
@pocmo
Closes mozilla-mobile#4282: Migrate feature-downloads to use browser-…
aec2986 
…state.
bors bot pushed a commit that referenced this issue Sep 13, 2019
@MozLando @pocmo
Merge #4390
0989780 
4390: Closes #4282: Migrate feature-downloads to use browser-state. r=csadilek a=pocmo

As discussed before this migrates everything in `feature-downloads` from `browser-session` to `browser-state`. The last part using `browser-session` is the newly introduced `DownloadsUseCases` for now.



Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
bors bot pushed a commit that referenced this issue Sep 13, 2019
@MozLando @ncalexan @pocmo
Merge #4152 #4390
1e303f8 
4152: Consume new `substitute-local-geckoview.gradle` script from Bug 1533465.  Fixes #4068. r=pocmo a=ncalexan

@pocmo this works for me locally.  The upstream script doesn't use `allprojects` (figured consumers can do that), but I'm not sure you really want to do this for all projects when it will impact ~50 projects.  Consider doing that or, or else plumb the single line into the relevant projecst (~7, it looked like to me).

4390: Closes #4282: Migrate feature-downloads to use browser-state. r=csadilek a=pocmo

As discussed before this migrates everything in `feature-downloads` from `browser-session` to `browser-state`. The last part using `browser-session` is the newly introduced `DownloadsUseCases` for now.



Co-authored-by: Nick Alexander <nalexander@mozilla.com>
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
@pocmo pocmo closed this as completed in 50f7a53 Sep 13, 2019
csadilek added a commit to csadilek/android-components that referenced this issue Sep 26, 2019
@csadilek
Isse mozilla-mobile#4282: Remove browser-session dependency from feat…
c03da6c 
…ure-downloads
csadilek added a commit to csadilek/android-components that referenced this issue Sep 26, 2019
@csadilek
Isse mozilla-mobile#4282: Remove browser-session dependency from feat…
68d258a 
…ure-downloads
csadilek added a commit to csadilek/android-components that referenced this issue Sep 26, 2019
@csadilek
Issue mozilla-mobile#4282: Remove browser-session dependency from fea…
e4a4375 
…ture-downloads
@csadilek csadilek mentioned this issue Sep 26, 2019
Merged
bors bot pushed a commit that referenced this issue Sep 26, 2019
@MozLando @csadilek
Merge #4543
53d22ea 
4543: Issue #4282: Remove browser-session dependency from feature-downloads r=pocmo a=csadilek

Just some cleanup we missed? in #4282

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
bors bot pushed a commit that referenced this issue Sep 26, 2019
@MozLando @csadilek
Merge #4543
7c62d36 
4543: Issue #4282: Remove browser-session dependency from feature-downloads r=pocmo a=csadilek

Just some cleanup we missed? in #4282

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
@grigoryk grigoryk mentioned this issue Nov 2, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
<download> Component: feature-download 🌟 feature New functionality and improvements <state> Component: browser-state
Projects
None yet
Milestone
13.0.0 🌌
Development

No branches or pull requests
2 participants
@pocmo @csadilek