Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add optional parameter Item Decoration in BrowserTabsTray #6895

Closed
mcarare opened this issue May 7, 2020 · 1 comment · Fixed by #6896
Closed

Add optional parameter Item Decoration in BrowserTabsTray #6895

mcarare opened this issue May 7, 2020 · 1 comment · Fixed by #6896
Assignees
@mcarare
Labels
🐉 Fenix Feature needed for Fenix <tabs> Components: browser-tabstray, feature-tabs

Comments

@mcarare
Copy link
Contributor

mcarare commented May 7, 2020 •
edited by data-sync-user
Loading

To avoid crashes like the one in mozilla-mobile/fenix#10453 we should provide an intuitive way to add item decoration. We should handle this in BrowserTabsTray internally, so we can make sure the setting of item decoration occurs in the right moment.

┆Issue is synchronized with this Jira Task
@mcarare mcarare added the 🐉 Fenix Feature needed for Fenix label May 7, 2020
@mcarare mcarare self-assigned this May 7, 2020
@pocmo pocmo added the <tabs> Components: browser-tabstray, feature-tabs label May 7, 2020
bors bot pushed a commit that referenced this issue May 7, 2020
@MozLando @mcarare
Merge #6896
7b56b42 
6896: For #6895: Add optional itemDecoration in browser tabs tray. r=psymoon a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
bors bot pushed a commit that referenced this issue May 7, 2020
@MozLando @mcarare
Merge #6896
9adccaa 
6896: For #6895: Add optional itemDecoration in browser tabs tray. r=psymoon a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
@boek boek added the E3 Estimation points: 3 label May 8, 2020
@gabrielluong gabrielluong linked a pull request May 8, 2020 that will close this issue
For #6895: Add optional itemDecoration in browser tabs tray. #6896
Merged
4 tasks
@boek boek removed the E3 Estimation points: 3 label May 8, 2020
@gabrielluong
Copy link
Member

Closing since this already landed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐉 Fenix Feature needed for Fenix <tabs> Components: browser-tabstray, feature-tabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #6895: Add optional itemDecoration in browser tabs tray.
5 participants
@pocmo @gabrielluong @boek @bifleming @mcarare