This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fullscreen feature: Do not invoke callbacks for initial state. #7723
Comments
pocmo
added a commit
to pocmo/android-components
that referenced
this issue
Jul 15, 2020
… for initial state.
bors bot
pushed a commit
that referenced
this issue
Jul 16, 2020
7724: Issue #7723: FullScreenFeature: Do not invoke callbacks for initial state. r=rocketsroger a=pocmo 7735: Import strings from android-l10n. r=pocmo a=mozilla-l10n-automation-bot n/t Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com> Co-authored-by: Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Fenix issue: mozilla-mobile/fenix#12424
Since we migrated
FullScreenFeaturefromSessionManagertoBrowserStorewe now invoke the callbacks with the initial state (e.g.fullScreenChanged(false)) on start. That is a behavior change and caused an issue in Fenix (see above). Since that is unnecessary to do (we only want to do something if we switch to fullscreen mode or back) we should just not do that in the feature.┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: