Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

SpeculativeSessionObserver is swallowing events meant to be for EngineObserver #8431

Closed
Amejia481 opened this issue Sep 17, 2020 · 0 comments
Closed

SpeculativeSessionObserver is swallowing events meant to be for EngineObserver #8431

Amejia481 opened this issue Sep 17, 2020 · 0 comments
Labels
🐞 bug Something isn't working
Milestone
60.0.0 👽

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Sep 17, 2020 •
edited by data-sync-user
Loading

In 68559df, we introduced SpeculativeSessionObserver with the goal of capturing early crashes but as a side effect it's consuming early events that were meant to be consumed by the EngineObserver, that it's the case of EngineObserver#onTrackerBlockingEnabledChange causing issues like mozilla-mobile/fenix#15152 where the EngineObserver got onTrackerBlockingEnabledChange as the SpeculativeSessionObserver consumed it before hand.

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added the 🐞 bug Something isn't working label Sep 17, 2020
@Amejia481 Amejia481 mentioned this issue Sep 17, 2020
Closed
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 17, 2020
@Amejia481
Closes mozilla-mobile#8431: Notify all new observes about
41720f4 
change on enableTrackingProtection
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 17, 2020
@Amejia481
Closes mozilla-mobile#8431: Notify all new observers about
63e8206 
change on enableTrackingProtection
bors bot pushed a commit that referenced this issue Sep 17, 2020
@MozLando @Amejia481
Merge #8432
e3029b7 
8432: Closes #8431: Notify all new observers about change on enableTrackingProtection r=pocmo a=Amejia481




Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@bors bors bot closed this as completed in fea3c72 Sep 17, 2020
@pocmo pocmo added this to the 60.0.0 👽 milestone Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
60.0.0 👽
Development

No branches or pull requests
2 participants
@pocmo @Amejia481