Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Optimize multi dispatch, specifically SessionManager.restore() #8535

Closed
pocmo opened this issue Sep 29, 2020 · 1 comment · Fixed by #8589
Closed

Optimize multi dispatch, specifically SessionManager.restore() #8535

pocmo opened this issue Sep 29, 2020 · 1 comment · Fixed by #8589
Assignees
Labels
performance Performance related issues <state> Component: browser-state
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Sep 29, 2020

We see SessionManager.restore() take quite some time. This is primarily caused by us doing a lot of sync dispatch calls. There are multiple options how we could fix that. The obvious choice is to let restore() use batch actions. Another option may be to have a generic batch { } that will group actions together and perform them in order - assuming that most of the overhead comes from the context switches.

┆Issue is synchronized with this Jira Task

@pocmo pocmo added performance Performance related issues <state> Component: browser-state labels Sep 29, 2020
@mcomella
Copy link
Contributor

iiuc, this work is for addressing the slowdown that occurs for having many tabs open on cold startup #7304

csadilek added a commit to csadilek/android-components that referenced this issue Oct 1, 2020
csadilek added a commit to csadilek/android-components that referenced this issue Oct 2, 2020
…ndividual actions to restore tabs

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
csadilek added a commit to csadilek/android-components that referenced this issue Oct 2, 2020
…ndividual actions to restore tabs

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
@mergify mergify bot closed this as completed in #8589 Oct 2, 2020
mergify bot pushed a commit that referenced this issue Oct 2, 2020
… tabs

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
@Amejia481 Amejia481 added this to the 62.0.0 🥮 milestone Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
performance Performance related issues <state> Component: browser-state
Projects
None yet
4 participants