Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Use the gecko fetch client when resuming a download #8904

Closed
Amejia481 opened this issue Nov 5, 2020 · 0 comments
Closed

Use the gecko fetch client when resuming a download #8904

Amejia481 opened this issue Nov 5, 2020 · 0 comments
Assignees
@Amejia481
Labels
🐞 bug Something isn't working <download> Component: feature-download
Milestone
66.0.0 🍟

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Nov 5, 2020 •
edited by data-sync-user
Loading

Before adding the new gecko view download API. We used to use the gecko fetch client that has the corresponding header for performing the resuming download. Now that we are always using the new API when available, resuming downloads are failing, as the new gv download API doesn't allow to pass headers we have to use the gecko fetch client when performing a resuming a download. Related issue mozilla-mobile/fenix#9354

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 added 🐞 bug Something isn't working <download> Component: feature-download labels Nov 5, 2020
@Amejia481 Amejia481 self-assigned this Nov 5, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 5, 2020
@Amejia481
Close mozilla-mobile#8904 Use the gecko fetch client
84dd542 
when resuming a download
@mergify mergify bot closed this as completed in afe67a5 Nov 6, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Nov 12, 2020
@Amejia481
Close mozilla-mobile#8904 Use the gecko fetch client
a8c075b 
when resuming a download
mergify bot pushed a commit that referenced this issue Nov 12, 2020
@Amejia481 @mergify
Close #8904 Use the gecko fetch client
ccd990d 
when resuming a download
@Amejia481 Amejia481 added this to the 66.0.0 milestone Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
🐞 bug Something isn't working <download> Component: feature-download
Projects
None yet
Milestone
66.0.0 🍟
Development

No branches or pull requests
1 participant
@Amejia481