Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support Pocket top stories #9189

Closed
Mugurell opened this issue Dec 10, 2020 · 0 comments · Fixed by #9193
Closed

Support Pocket top stories #9189

Mugurell opened this issue Dec 10, 2020 · 0 comments · Fixed by #9193
Assignees
@Mugurell
Labels
🌟 feature New functionality and improvements <pocket> Component: Service-pocket

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Dec 10, 2020 •
edited by data-sync-user
Loading

Fennec and other Mozilla apps supported this.
Fenix is preparing to add this also. Tracking ticket - mozilla-mobile/fenix#16638
AC could help with this by containing all logic needed for:

  • downloading global recommended articles,
  • persisting them locally for a specified time to ease network activity
  • allowing clients to easily get the list of articles with all details abstracted in AC

There is already support for video recommendations - initially added in #651 oferring this for Fire TV devices.

Requirements:

  1. Add similar support for downloading Pocket recommended articles.
    Following the Fennec implementation from https://bugzilla.mozilla.org/show_bug.cgi?id=1380808 we should update service.pocket with the following:
  • endpoint: https://getpocket.cdn.mozilla.net/v3/firefox/global-recs
  • authentication: consumer_key - secret api key added as a request parameter
  • supported query parameters:
    • count - number of items to download from Pocket. Fennec and Fenix would use 3.
      Default is 20.
    • locale - ISO 639 language code that allows getting recommended articles for particular locales.
      Default may be "en-US"
  • a valid userAgent is also a current requirement. Not sure we need this though or maybe we can just offer a default one.
  1. Create a new feature.pocket-recommendations that would allow client easily getting a list of recommended Pocket articles:
  • configure and use service.pocket to download Pocket articles
  • support a local cache of the articles to lower network activity. Fennec used a timeout of 1 hour as a refresh timeout
  • ensure we are not sending refreshed items while the user is looking at / interacting with the previous articles (bad UX)

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Dec 10, 2020
Mugurell added a commit to Mugurell/android-components that referenced this issue Dec 10, 2020
@Mugurell
For mozilla-mobile#9189 - Support fetching Pocket recommended articles
bad088b
Mugurell added a commit to Mugurell/android-components that referenced this issue Dec 10, 2020
@Mugurell
For mozilla-mobile#9189 - New feature-pocket-recommendations
c7eab0a 
This would download, cache, offer Pocket recommended articles.
Mugurell added a commit to Mugurell/android-components that referenced this issue Dec 10, 2020
@Mugurell
For mozilla-mobile#9189 - New feature-pocket-recommendations
a34827c 
This would download, cache, offer Pocket recommended articles.
@pocmo pocmo added <pocket> Component: Service-pocket 🌟 feature New functionality and improvements labels Dec 11, 2020
Mugurell added a commit to Mugurell/android-components that referenced this issue Dec 21, 2020
@Mugurell
For mozilla-mobile#9189 - Refactor service-pocket to support recommen…
1b6e030 
…ded articles.

Since the previous version of this component was not in use anymore it was used
as a starting point for the newly needed functionality - easily offering Pocket
recommended articles to interested clients.

The new version offers a simple API for downloading, caching and refreshing in
the background the list of Pocket articles that is offered to clients.
Mugurell added a commit to Mugurell/android-components that referenced this issue Dec 21, 2020
@Mugurell
For mozilla-mobile#9189 - Refactor service-pocket to support recommen…
bf9855f 
…ded articles.

Since the previous version of this component was not in use anymore it was used
as a starting point for the newly needed functionality - easily offering Pocket
recommended articles to interested clients.

The new version offers a simple API for downloading, caching and refreshing in
the background the list of Pocket articles that is offered to clients.
Mugurell added a commit to Mugurell/android-components that referenced this issue Dec 21, 2020
@Mugurell
For mozilla-mobile#9189 - Refactor service-pocket to support recommen…
8176d00 
…ded articles.

Since the previous version of this component was not in use anymore it was used
as a starting point for the newly needed functionality - easily offering Pocket
recommended articles to interested clients.

The new version offers a simple API for downloading, caching and refreshing in
the background the list of Pocket articles that is offered to clients.
Mugurell added a commit to Mugurell/android-components that referenced this issue May 12, 2021
@Mugurell
For mozilla-mobile#9189 - Refactor service-pocket to support recommen…
a5bbef8 
…ded articles.

Since the previous version of this component was not in use anymore it was used
as a starting point for the newly needed functionality - easily offering Pocket
recommended articles to interested clients.

The new version offers a simple API for downloading, caching and refreshing in
the background the list of Pocket articles that is offered to clients.
Mugurell added a commit to Mugurell/android-components that referenced this issue May 12, 2021
@Mugurell
For mozilla-mobile#9189 - Refactor service-pocket to support recommen…
385ba0c 
…ded articles.

Since the previous version of this component was not in use anymore it was used
as a starting point for the newly needed functionality - easily offering Pocket
recommended articles to interested clients.

The new version offers a simple API for downloading, caching and refreshing in
the background the list of Pocket articles that is offered to clients.
Mugurell added a commit to Mugurell/android-components that referenced this issue May 13, 2021
@Mugurell
For mozilla-mobile#9189 - Refactor service-pocket to support recommen…
34d7049 
…ded articles.

Since the previous version of this component was not in use anymore it was used
as a starting point for the newly needed functionality - easily offering Pocket
recommended articles to interested clients.

The new version offers a simple API for downloading, caching and refreshing in
the background the list of Pocket articles that is offered to clients.
mergify bot pushed a commit that referenced this issue May 13, 2021
@Mugurell @mergify
For #9189 - Refactor service-pocket to support recommended articles.
b5e8dd8 
Since the previous version of this component was not in use anymore it was used
as a starting point for the newly needed functionality - easily offering Pocket
recommended articles to interested clients.

The new version offers a simple API for downloading, caching and refreshing in
the background the list of Pocket articles that is offered to clients.
@gabrielluong gabrielluong mentioned this issue May 31, 2021
Merged
4 tasks
@gabrielluong gabrielluong added this to the 90.0.0 🌳 milestone May 31, 2021
@pocmo pocmo modified the milestones: 90.0.0 🌳, 91.0.0 🐊 Jun 1, 2021
@pocmo pocmo removed this from the 91.0.0 🐊 milestone Aug 3, 2021
grigoryk pushed a commit to gabrielluong/android-components that referenced this issue Sep 11, 2021
@Mugurell
For mozilla-mobile#9189 - Refactor service-pocket to support recommen…
fe99a53 
…ded articles.

Since the previous version of this component was not in use anymore it was used
as a starting point for the newly needed functionality - easily offering Pocket
recommended articles to interested clients.

The new version offers a simple API for downloading, caching and refreshing in
the background the list of Pocket articles that is offered to clients.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
🌟 feature New functionality and improvements <pocket> Component: Service-pocket
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #9189 - Pocket articles support Mugurell/android-components
3 participants
@pocmo @gabrielluong @Mugurell