Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

[Bug] LinkEngineSessionAction does not consider restoreState result #9445

Closed
mcarare opened this issue Jan 19, 2021 · 1 comment
Closed

[Bug] LinkEngineSessionAction does not consider restoreState result #9445

mcarare opened this issue Jan 19, 2021 · 1 comment
Assignees
@mcarare
Labels
🐞 bug Something isn't working <engine-gecko> Component: browser-engine-gecko <tabs> Components: browser-tabstray, feature-tabs
Milestone
71.0.0 🐈

Comments

@mcarare
Copy link
Contributor

mcarare commented Jan 19, 2021 •
edited by data-sync-user
Loading

Fenix issue: mozilla-mobile/fenix#16259.

There are 2 issues here that cause the Fenix bug:

  1. In some cases state.actualState might not be null but still empty.
  2. In createEngineSession if engineSessionState is not null, skipLoading is always true, even if restoreState returns false.

So, we should also check if actualState is empty and do not skip loading when we could not restore state.

┆Issue is synchronized with this Jira Task
@mcarare mcarare added 🐞 bug Something isn't working <engine-gecko> Component: browser-engine-gecko <tabs> Components: browser-tabstray, feature-tabs labels Jan 19, 2021
@mcarare mcarare self-assigned this Jan 19, 2021
mergify bot pushed a commit that referenced this issue Jan 20, 2021
@mcarare @mergify
For #9445: On restoring state also check if actual state is empty.
98cf1d4
mergify bot pushed a commit that referenced this issue Jan 20, 2021
@mcarare @mergify
For #9445: SkipLoading should depend on restoreState return value.
06ae87a
@Amejia481 Amejia481 added this to the 71.0.0 milestone Jan 20, 2021
@mcarare
Copy link
Contributor Author

mcarare commented Jan 26, 2021

Closing this as the original Fenis issue is verified as fixed: mozilla-mobile/fenix#16259 (comment).

@mcarare mcarare closed this as completed Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Something isn't working <engine-gecko> Component: browser-engine-gecko <tabs> Components: browser-tabstray, feature-tabs
Projects
None yet
Milestone
71.0.0 🐈
Development

No branches or pull requests
2 participants
@Amejia481 @mcarare