Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Don't animate the dynamic toolbar while tab is loading #9770

Closed
Mugurell opened this issue Feb 24, 2021 · 1 comment
Closed

Don't animate the dynamic toolbar while tab is loading #9770

Mugurell opened this issue Feb 24, 2021 · 1 comment
Assignees
@Mugurell
Labels
<toolbar> Components: browser-toolbar, concept-toolbar
Milestone
74.0.0 ⚒

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Feb 24, 2021 •
edited by data-sync-user
Loading

Needed for this Fenix issue - mozilla-mobile/fenix#18034
(and probably others)

Chrome doesn't animate the toolbar while the page is loading.
We should probably do the same with this helping avoid some layout issues.

Confirmed this UX direction with Nicole.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added the <toolbar> Components: browser-toolbar, concept-toolbar label Feb 24, 2021
@Mugurell Mugurell self-assigned this Feb 24, 2021
Mugurell added a commit to Mugurell/android-components that referenced this issue Feb 24, 2021
@Mugurell
For mozilla-mobile#9770 - Don't animate the dynamic toolbar while tab…
9b6846a 
… is loading

Toolbar will not be animated while the tab is loading irrespective of the
intrinsic checks made in the BrowserToolbarBehavior - whether the touch is a
vertical scroll and it was handled by GeckoView.
Mugurell added a commit to Mugurell/android-components that referenced this issue Feb 24, 2021
@Mugurell
For mozilla-mobile#9770 - Don't animate the dynamic toolbar while tab…
be95dc1 
… is loading

Toolbar will not be animated while the tab is loading irrespective of the
intrinsic checks made in the BrowserToolbarBehavior - whether the touch is a
vertical scroll and it was handled by GeckoView.
Mugurell added a commit to Mugurell/android-components that referenced this issue Feb 25, 2021
@Mugurell
For mozilla-mobile#9770 - Don't animate the dynamic toolbar while tab…
23b1355 
… is loading

Toolbar will not be animated while the tab is loading irrespective of the
intrinsic checks made in the BrowserToolbarBehavior - whether the touch is a
vertical scroll and it was handled by GeckoView.
mergify bot pushed a commit that referenced this issue Mar 1, 2021
@Mugurell @mergify
For #9770 - Don't animate the dynamic toolbar while tab is loading
5b22f58 
Toolbar will not be animated while the tab is loading irrespective of the
intrinsic checks made in the BrowserToolbarBehavior - whether the touch is a
vertical scroll and it was handled by GeckoView.
@Mugurell
Copy link
Contributor Author

Mugurell commented Mar 3, 2021

This is ready to be used.
Closing the ticket.

@Mugurell Mugurell closed this as completed Mar 3, 2021
@gabrielluong gabrielluong added this to the 74.0.0 milestone Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
<toolbar> Components: browser-toolbar, concept-toolbar
Projects
None yet
Milestone
74.0.0 ⚒
Development

No branches or pull requests
2 participants
@gabrielluong @Mugurell