This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
For #10005 - Replace layout manager to effectively change stackFromEnd #10006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10006 +/- ##
============================================
+ Coverage 74.12% 75.42% +1.30%
+ Complexity 5833 1375 -4458
============================================
Files 786 225 -561
Lines 29199 6255 -22944
Branches 4799 936 -3863
============================================
- Hits 21644 4718 -16926
+ Misses 5046 1136 -3910
+ Partials 2509 401 -2108 Continue to review full report at Codecov.
|
Amejia481
approved these changes
Apr 6, 2021
…ge stackFromEnd The `stackFromEnd` property is not initially set even though `endOfMenuAlwaysVisible` might be true since when having a bottom expandable menu, that should always be scrolled to the top. And we know if we're in that situation only later, after menu is configured and based on it it can be inferred if it should be collapsed or not. Setting `stackFromEnd` only after this steps, even if the menu is not yet on the screen seems to have no effect. The only solution is to replace menu's layout manager with one that has this `stackFromEnd` from the beginning.
Mugurell
force-pushed
the
endOfMenuAlwaysVisible
branch
from
c61a60f to
e05792a
Compare
Mugurell
added
🛬 needs landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10005
The
stackFromEndproperty is not initially set even thoughendOfMenuAlwaysVisiblemight be true since when having a bottom expandablemenu, that should always be scrolled to the top.
And we know if we're in that situation only later, after menu is configured and
based on it it can be inferred if it should be collapsed or not.
Setting
stackFromEndonly after this steps, even if the menu is not yet onthe screen seems to have no effect.
The only solution is to replace menu's layout manager with one that has this
stackFromEndfrom the beginning.FullHeightMenu.mp4
CollpasedMenu.mp4
Pull Request checklist
After merge