This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Issue #10611 - Add a new SelectOrAddUseCase for reopening existing tab with matching HistoryMetadataKey #10593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadilek
reviewed
Jul 14, 2021
components/feature/tabs/src/main/java/mozilla/components/feature/tabs/TabsUseCases.kt
Outdated
Show resolved
Hide resolved
gabrielluong
changed the title
gabrielluong
force-pushed
the
history-metadata-use-case
branch
6 times, most recently
from
de40778 to
04126e3
Compare
…ng existing tab with matching HistoryMetadataKey
gabrielluong
force-pushed
the
history-metadata-use-case
branch
from
04126e3 to
857a125
Compare
csadilek
approved these changes
Jul 15, 2021
| /** | ||
| * Selects an already existing tab displaying [url] or otherwise creates a new tab. | ||
| * | ||
| * @param url The URL to be loaded in the new tab. | ||
| * @param private Whether or not this session should use private mode. |
There was a problem hiding this comment.
This is actually a bug for the found and selected case but we have it on file: #10560 to address outside of this.
gabrielluong
force-pushed
the
history-metadata-use-case
branch
from
d479352 to
857a125
Compare
|
All green, but mergify didn't pick it up, will land it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10611
Pull Request checklist
After merge