This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
For # #11374 - Restore immersive mode #11375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts when rebasing. Could you fix it @Mugurell? 🙏 |
Amejia481
reviewed
Jan 5, 2022
components/support/ktx/src/main/java/mozilla/components/support/ktx/android/view/Activity.kt
Outdated
Show resolved
Hide resolved
Amejia481
reviewed
Jan 5, 2022
...onents/support/ktx/src/test/java/mozilla/components/support/ktx/android/view/ActivityTest.kt
Outdated
Show resolved
Hide resolved
Amejia481
reviewed
Jan 5, 2022
| if (insets.isVisible(statusBars())) { | ||
| setAsImmersive() | ||
| } | ||
| insets |
There was a problem hiding this comment.
nit: Do we need insets here? As it doesn't looks as we are using it.
There was a problem hiding this comment.
It's the return of windowInsetsListener.
The onApplyWindowInsets method must return WindowInsets - https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:core/core/src/main/java/androidx/core/view/OnApplyWindowInsetsListener.java;l=45;drc=cb04420e742501081487e3b18851d5674dc07536
Amejia481
reviewed
Jan 5, 2022
docs/changelog.md
Outdated
| @@ -11,6 +11,9 @@ permalink: /changelog/ | |||
| * [Gecko](https://github.com/mozilla-mobile/android-components/blob/main/buildSrc/src/main/java/Gecko.kt) | |||
| * [Configuration](https://github.com/mozilla-mobile/android-components/blob/main/.config.yml) | |||
|
|
|||
| * **support-ktx** | |||
| * 🚒 Bug fixed [issue #11374](https://github.com/mozilla-mobile/android-components/issues/11374) - Restore immersive mode after interacting with other Windows. Handle this internally without clients having to pass a OnWindowFocusChangeListener. | |||
There was a problem hiding this comment.
nit: I think we should mention that we have a breaking change on enterToImmersiveMode
There was a problem hiding this comment.
Thanks! Will update!
Amejia481
approved these changes
Jan 5, 2022
Mugurell
force-pushed
the
restoreImmersiveMode
branch
from
f771c84 to
563780f
Compare
…stener Previously we'd allow a listener being passed in and we'd hope it will correctly handle restoring immersive mode. Now we are handling focus changes and restoring immersive mode on ourselves also allowing for a simpler public API.
Mugurell
force-pushed
the
restoreImmersiveMode
branch
from
563780f to
6a54655
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an issue not reproducing on all devices.
Added a new insets listener to know when they change and set again immersive mode for the fullscreen Activity. (same as Chrome uses)
Handle focus changes internally to guarantee that these events will also restore immersive mode whereas previously clients could pass any focus listener even one not knowing to restore the immersive mode.
StatusBarShowingForFullscreenVideo.mp4
StatusBarHidingForFullscreenVideo.mp4
Pull Request checklist
After merge