Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Catches exceptions from deleteEverything in sync history storage #12112

Merged
merged 3 commits into from
May 9, 2022

Conversation

tarikeshaq
Copy link
Contributor

@tarikeshaq tarikeshaq commented May 5, 2022

fixes the crash in mozilla/application-services#4856

I'll keep that ticket open for investigation for root-cause, but regardless SQL errors while executing this function shouldn't crash the app

Pull Request checklist

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@tarikeshaq tarikeshaq changed the title Catches exceptions from deleteEverything Catches exceptions from deleteEverything in sync history storage May 5, 2022
@tarikeshaq tarikeshaq added the 🕵️‍♀️ needs review PRs that need to be reviewed label May 5, 2022
@gabrielluong gabrielluong removed the 🕵️‍♀️ needs review PRs that need to be reviewed label May 9, 2022
@tarikeshaq tarikeshaq added the 🛬 needs landing (squash) PRs that are ready to land (squashed) label May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing (squash) PRs that are ready to land (squashed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants