Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #12258 - Retry deleting Pocket profile if initially failed #12259

Merged
merged 1 commit into from
May 31, 2022
Merged

For #12258 - Retry deleting Pocket profile if initially failed #12259

merged 1 commit into from
May 31, 2022

Conversation

Mugurell
Copy link
Contributor

It's important to ensure the profile is deleted when the sponsored stories
feature is disabled but since this involves a network call which may fail we
need to support retrying a previous failed request until profile deletion is
successful or the sponsored stories functionality is started again.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@mergify
Copy link
Contributor

mergify bot commented May 31, 2022

This pull request has conflicts when rebasing. Could you fix it @Mugurell? 🙏

@Mugurell Mugurell mentioned this pull request May 31, 2022
Merged
3 tasks
mcarare
mcarare approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@mcarare mcarare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mugurell
For mozilla-mobile#12258 - Retry deleting Pocket profile if initially…
6fd195d 
… failed

It's important to ensure the profile is deleted when the sponsored stories
feature is disabled but since this involves a network call which may fail we
need to support retrying a previous failed request until profile deletion is
successful or the sponsored stories functionality is started again.
@Mugurell
Copy link
Contributor Author

Rebased to fix changelog conflict.

@Mugurell Mugurell force-pushed the ensureProfileDeletion branch from 7342567 to 6fd195d Compare May 31, 2022 10:43
@Mugurell Mugurell added the 🛬 needs landing PRs that are ready to land label May 31, 2022
@mergify mergify bot merged commit 8732feb into mozilla-mobile:main May 31, 2022
@Mugurell Mugurell deleted the ensureProfileDeletion branch June 2, 2022 13:56
@csadilek csadilek mentioned this pull request Oct 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcarare mcarare mcarare approved these changes

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugurell @mcarare