Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #12562 - Handle onPromptDismiss in ChoicePromptDelegate #12563

Merged
merged 2 commits into from
Aug 8, 2022
Merged

For #12562 - Handle onPromptDismiss in ChoicePromptDelegate #12563

merged 2 commits into from
Aug 8, 2022

Conversation

Alexandru2909
Copy link
Contributor

@Alexandru2909 Alexandru2909 commented Jul 28, 2022 •
edited by github-actions bot
Loading

Added onPromptDismiss callback in ChoicePromptDelegate.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Fixes #12562

Mugurell
Mugurell approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alexandru2909 Alexandru2909 added the 🛬 needs landing PRs that are ready to land label Aug 8, 2022
@mergify mergify bot merged commit dc028b5 into mozilla-mobile:main Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mugurell Mugurell Mugurell approved these changes

@Amejia481 Amejia481 Awaiting requested review from Amejia481

@csadilek csadilek Awaiting requested review from csadilek csadilek is a code owner

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle onPromptDismiss in ChoicePrompt instance delegate
2 participants
@Alexandru2909 @Mugurell