This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
[glean] 1535083: Use enums as extra keys on events #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
approved these changes
Mar 19, 2019
| // a template parameter). | ||
| if (it.size > 0) { | ||
| val cls = it.keys.first().javaClass | ||
| val method = cls.getDeclaredMethod("getValue") |
There was a problem hiding this comment.
Eugh, I hoped we could make it without it. But we can't :) No problem!
travis79
approved these changes
Mar 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #2403 +/- ##
============================================
- Coverage 83.74% 83.58% -0.16%
+ Complexity 2729 2672 -57
============================================
Files 334 325 -9
Lines 11355 11216 -139
Branches 1658 1637 -21
============================================
- Hits 9509 9375 -134
- Misses 1163 1166 +3
+ Partials 683 675 -8
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses enums for the extra keys on events so they are checked at build time rather than run time.
This won't pass CI until mozilla/glean_parser#44 is merged and this PR is updated to use that.
Pull Request checklist