This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Always set 'wasMigrated' to false in the Glean SDK #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only useful as a safety measure in case the data migration plan goes wrong and we're forced to downgrade the version Glean SDK consumers are using from glean-core to glean-ac. In that case, this code will run and will reset the status of the migration. When attempting the upgrade again, glean-core will perform the migration one more time.
|
This is a complement to mozilla/glean#309 |
chutten
approved these changes
Sep 24, 2019
badboy
approved these changes
Sep 24, 2019
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 24, 2019
4511: Always set 'wasMigrated' to false in the Glean SDK r=Dexterp37 a=Dexterp37 This is only useful as a safety measure in case the data migration plan goes wrong and we're forced to downgrade the version Glean SDK consumers are using from glean-core to glean-ac. In that case, this code will run and will reset the status of the migration. When attempting the upgrade again, glean-core will perform the migration one more time. Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only useful as a safety measure in case the data migration plan goes wrong and we're forced to downgrade the version Glean SDK consumers are using from glean-core to glean-ac. In that case, this code will run and will reset the status of the migration. When attempting the upgrade again, glean-core will perform the migration one more time.
Pull Request checklist
After merge